feat(ast): Add AstKind to TSRestType node (#11752)

This PR is part of the ongoing work in #11490.

Adds AstKind to `TSRestType` nodes by removing the entry from the list
of exceptions in ast_tools.

---------

Co-authored-by: Cameron Clark <cameron.clark@hey.com>

Author: therewillbecode

crates/oxc_ast/src/ast_kind_impl.rs

@@ -338,6 +338,8 @@ impl AstKind<'_> {
 
             Self::TSIndexedAccessType(_) => "TSIndexedAccessType".into(),
 
+            Self::TSRestType(_) => "TSRestType".into(),
+
             Self::TSAsExpression(_) => "TSAsExpression".into(),
             Self::TSSatisfiesExpression(_) => "TSSatisfiesExpression".into(),
             Self::TSNonNullExpression(_) => "TSNonNullExpression".into(),

crates/oxc_ast/src/generated/ast_kind.rs

@@ -140,56 +140,57 @@ pub enum AstType {
     TSTupleType = 124,
     TSNamedTupleMember = 125,
     TSOptionalType = 126,
-    TSAnyKeyword = 127,
-    TSStringKeyword = 128,
-    TSBooleanKeyword = 129,
-    TSNumberKeyword = 130,
-    TSNeverKeyword = 131,
-    TSIntrinsicKeyword = 132,
-    TSUnknownKeyword = 133,
-    TSNullKeyword = 134,
-    TSUndefinedKeyword = 135,
-    TSVoidKeyword = 136,
-    TSSymbolKeyword = 137,
-    TSThisType = 138,
-    TSObjectKeyword = 139,
-    TSBigIntKeyword = 140,
-    TSTypeReference = 141,
-    TSTypeName = 142,
-    TSQualifiedName = 143,
-    TSTypeParameterInstantiation = 144,
-    TSTypeParameter = 145,
-    TSTypeParameterDeclaration = 146,
-    TSTypeAliasDeclaration = 147,
-    TSClassImplements = 148,
-    TSInterfaceDeclaration = 149,
-    TSPropertySignature = 150,
-    TSCallSignatureDeclaration = 151,
-    TSMethodSignature = 152,
-    TSConstructSignatureDeclaration = 153,
-    TSIndexSignatureName = 154,
-    TSInterfaceHeritage = 155,
-    TSTypePredicate = 156,
-    TSModuleDeclaration = 157,
-    TSModuleBlock = 158,
-    TSTypeLiteral = 159,
-    TSInferType = 160,
-    TSTypeQuery = 161,
-    TSImportType = 162,
-    TSMappedType = 163,
-    TSTemplateLiteralType = 164,
-    TSAsExpression = 165,
-    TSSatisfiesExpression = 166,
-    TSTypeAssertion = 167,
-    TSImportEqualsDeclaration = 168,
-    TSExternalModuleReference = 169,
-    TSNonNullExpression = 170,
-    Decorator = 171,
-    TSExportAssignment = 172,
-    TSInstantiationExpression = 173,
-    JSDocNullableType = 174,
-    JSDocNonNullableType = 175,
-    JSDocUnknownType = 176,
+    TSRestType = 127,
+    TSAnyKeyword = 128,
+    TSStringKeyword = 129,
+    TSBooleanKeyword = 130,
+    TSNumberKeyword = 131,
+    TSNeverKeyword = 132,
+    TSIntrinsicKeyword = 133,
+    TSUnknownKeyword = 134,
+    TSNullKeyword = 135,
+    TSUndefinedKeyword = 136,
+    TSVoidKeyword = 137,
+    TSSymbolKeyword = 138,
+    TSThisType = 139,
+    TSObjectKeyword = 140,
+    TSBigIntKeyword = 141,
+    TSTypeReference = 142,
+    TSTypeName = 143,
+    TSQualifiedName = 144,
+    TSTypeParameterInstantiation = 145,
+    TSTypeParameter = 146,
+    TSTypeParameterDeclaration = 147,
+    TSTypeAliasDeclaration = 148,
+    TSClassImplements = 149,
+    TSInterfaceDeclaration = 150,
+    TSPropertySignature = 151,
+    TSCallSignatureDeclaration = 152,
+    TSMethodSignature = 153,
+    TSConstructSignatureDeclaration = 154,
+    TSIndexSignatureName = 155,
+    TSInterfaceHeritage = 156,
+    TSTypePredicate = 157,
+    TSModuleDeclaration = 158,
+    TSModuleBlock = 159,
+    TSTypeLiteral = 160,
+    TSInferType = 161,
+    TSTypeQuery = 162,
+    TSImportType = 163,
+    TSMappedType = 164,
+    TSTemplateLiteralType = 165,
+    TSAsExpression = 166,
+    TSSatisfiesExpression = 167,
+    TSTypeAssertion = 168,
+    TSImportEqualsDeclaration = 169,
+    TSExternalModuleReference = 170,
+    TSNonNullExpression = 171,
+    Decorator = 172,
+    TSExportAssignment = 173,
+    TSInstantiationExpression = 174,
+    JSDocNullableType = 175,
+    JSDocNonNullableType = 176,
+    JSDocUnknownType = 177,
 }
 
 /// Untyped AST Node Kind
@@ -330,6 +331,7 @@ pub enum AstKind<'a> {
     TSTupleType(&'a TSTupleType<'a>) = AstType::TSTupleType as u8,
     TSNamedTupleMember(&'a TSNamedTupleMember<'a>) = AstType::TSNamedTupleMember as u8,
     TSOptionalType(&'a TSOptionalType<'a>) = AstType::TSOptionalType as u8,
+    TSRestType(&'a TSRestType<'a>) = AstType::TSRestType as u8,
     TSAnyKeyword(&'a TSAnyKeyword) = AstType::TSAnyKeyword as u8,
     TSStringKeyword(&'a TSStringKeyword) = AstType::TSStringKeyword as u8,
     TSBooleanKeyword(&'a TSBooleanKeyword) = AstType::TSBooleanKeyword as u8,
@@ -531,6 +533,7 @@ impl GetSpan for AstKind<'_> {
             Self::TSTupleType(it) => it.span(),
             Self::TSNamedTupleMember(it) => it.span(),
             Self::TSOptionalType(it) => it.span(),
+            Self::TSRestType(it) => it.span(),
             Self::TSAnyKeyword(it) => it.span(),
             Self::TSStringKeyword(it) => it.span(),
             Self::TSBooleanKeyword(it) => it.span(),
@@ -1221,6 +1224,11 @@ impl<'a> AstKind<'a> {
         if let Self::TSOptionalType(v) = self { Some(v) } else { None }
     }
 
+    #[inline]
+    pub fn as_ts_rest_type(self) -> Option<&'a TSRestType<'a>> {
+        if let Self::TSRestType(v) = self { Some(v) } else { None }
+    }
+
     #[inline]
     pub fn as_ts_any_keyword(self) -> Option<&'a TSAnyKeyword> {
         if let Self::TSAnyKeyword(v) = self { Some(v) } else { None }

crates/oxc_ast_visit/src/generated/visit.rs

@@ -3394,9 +3394,11 @@ pub mod walk {
 
     #[inline]
     pub fn walk_ts_rest_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSRestType<'a>) {
-        // No `AstKind` for this type
+        let kind = AstKind::TSRestType(visitor.alloc(it));
+        visitor.enter_node(kind);
         visitor.visit_span(&it.span);
         visitor.visit_ts_type(&it.type_annotation);
+        visitor.leave_node(kind);
     }
 
     #[inline]

crates/oxc_ast_visit/src/generated/visit_mut.rs

@@ -3564,9 +3564,11 @@ pub mod walk_mut {
 
     #[inline]
     pub fn walk_ts_rest_type<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut TSRestType<'a>) {
-        // No `AstType` for this type
+        let kind = AstType::TSRestType;
+        visitor.enter_node(kind);
         visitor.visit_span(&mut it.span);
         visitor.visit_ts_type(&mut it.type_annotation);
+        visitor.leave_node(kind);
     }
 
     #[inline]

crates/oxc_formatter/src/generated/ast_nodes.rs

@@ -154,6 +154,7 @@ pub enum AstNodes<'a> {
     TSTupleType(&'a AstNode<'a, TSTupleType<'a>>),
     TSNamedTupleMember(&'a AstNode<'a, TSNamedTupleMember<'a>>),
     TSOptionalType(&'a AstNode<'a, TSOptionalType<'a>>),
+    TSRestType(&'a AstNode<'a, TSRestType<'a>>),
     TSAnyKeyword(&'a AstNode<'a, TSAnyKeyword>),
     TSStringKeyword(&'a AstNode<'a, TSStringKeyword>),
     TSBooleanKeyword(&'a AstNode<'a, TSBooleanKeyword>),
@@ -337,6 +338,7 @@ impl<'a> AstNodes<'a> {
             Self::TSTupleType(n) => n.span(),
             Self::TSNamedTupleMember(n) => n.span(),
             Self::TSOptionalType(n) => n.span(),
+            Self::TSRestType(n) => n.span(),
             Self::TSAnyKeyword(n) => n.span(),
             Self::TSStringKeyword(n) => n.span(),
             Self::TSBooleanKeyword(n) => n.span(),
@@ -520,6 +522,7 @@ impl<'a> AstNodes<'a> {
             Self::TSTupleType(n) => n.parent,
             Self::TSNamedTupleMember(n) => n.parent,
             Self::TSOptionalType(n) => n.parent,
+            Self::TSRestType(n) => n.parent,
             Self::TSAnyKeyword(n) => n.parent,
             Self::TSStringKeyword(n) => n.parent,
             Self::TSBooleanKeyword(n) => n.parent,
@@ -703,6 +706,7 @@ impl<'a> AstNodes<'a> {
             Self::TSTupleType(_) => "TSTupleType",
             Self::TSNamedTupleMember(_) => "TSNamedTupleMember",
             Self::TSOptionalType(_) => "TSOptionalType",
+            Self::TSRestType(_) => "TSRestType",
             Self::TSAnyKeyword(_) => "TSAnyKeyword",
             Self::TSStringKeyword(_) => "TSStringKeyword",
             Self::TSBooleanKeyword(_) => "TSBooleanKeyword",
@@ -6054,7 +6058,7 @@ impl<'a> AstNode<'a, TSRestType<'a>> {
         self.allocator.alloc(AstNode {
             inner: &self.inner.type_annotation,
             allocator: self.allocator,
-            parent: self.parent,
+            parent: self.allocator.alloc(AstNodes::TSRestType(transmute_self(self))),
         })
     }
 }
@@ -6071,11 +6075,11 @@ impl<'a> AstNode<'a, TSTupleElement<'a>> {
                     allocator: self.allocator,
                 }))
             }
-            TSTupleElement::TSRestType(s) => {
-                panic!(
-                    "No kind for current enum variant yet, please see `tasks/ast_tools/src/generators/ast_kind.rs`"
-                )
-            }
+            TSTupleElement::TSRestType(s) => AstNodes::TSRestType(self.allocator.alloc(AstNode {
+                inner: s.as_ref(),
+                parent,
+                allocator: self.allocator,
+            })),
             it @ match_ts_type!(TSTupleElement) => {
                 return self
                     .allocator

crates/oxc_formatter/src/generated/format.rs

@@ -1564,7 +1564,10 @@ impl<'a> Format<'a> for AstNode<'a, TSOptionalType<'a>> {
 
 impl<'a> Format<'a> for AstNode<'a, TSRestType<'a>> {
     fn fmt(&self, f: &mut Formatter<'_, 'a>) -> FormatResult<()> {
-        self.write(f)
+        format_leading_comments(self.span().start).fmt(f)?;
+        let result = self.write(f);
+        format_trailing_comments(self.span().end).fmt(f)?;
+        result
     }
 }
 

crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/tuple-labelled-rest.snap

@@ -34,7 +34,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ReferenceFlags(Type)",
             "id": 0,
             "name": "T",
-            "node_id": 13
+            "node_id": 14
           }
         ]
       },

crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/tuple-rest.snap

@@ -34,7 +34,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ReferenceFlags(Type)",
             "id": 0,
             "name": "T",
-            "node_id": 10
+            "node_id": 11
           }
         ]
       },

tasks/ast_tools/src/generators/ast_kind.rs

@@ -37,7 +37,6 @@ const STRUCTS_BLACK_LIST: &[&str] = &[
     "BindingProperty",
     "AccessorProperty",
     "ImportAttribute",
-    "TSRestType",
     "TSInterfaceBody",
     "TSIndexSignature",
     "TSFunctionType",