fix(language_server): build releated spans from "0" instead of MAX_LSP_INT

Author: Sysix

crates/oxc_language_server/src/linter/error_with_position.rs

@@ -8,8 +8,6 @@ use tower_lsp_server::lsp_types::{
 
 use oxc_diagnostics::Severity;
 
-use crate::LSP_MAX_INT;
-
 #[derive(Debug, Clone, Default)]
 pub struct DiagnosticReport {
     pub diagnostic: lsp_types::Diagnostic,
@@ -72,17 +70,11 @@ fn message_with_position_to_lsp_diagnostic(
     });
 
     let range = related_information.as_ref().map_or(
-        Range {
-            start: Position { line: LSP_MAX_INT, character: LSP_MAX_INT },
-            end: Position { line: LSP_MAX_INT, character: LSP_MAX_INT },
-        },
+        Range::default(),
         |infos: &Vec<DiagnosticRelatedInformation>| {
-            let mut ret_range = Range {
-                start: Position { line: LSP_MAX_INT, character: LSP_MAX_INT },
-                end: Position { line: LSP_MAX_INT, character: LSP_MAX_INT },
-            };
+            let mut ret_range = Range::default();
             for info in infos {
-                if cmp_range(&ret_range, &info.location.range) == std::cmp::Ordering::Greater {
+                if cmp_range(&ret_range, &info.location.range) == std::cmp::Ordering::Less {
                     ret_range = info.location.range;
                 }
             }

crates/oxc_language_server/src/main.rs

@@ -19,10 +19,6 @@ type ConcurrentHashMap<K, V> = papaya::HashMap<K, V, FxBuildHasher>;
 
 const OXC_CONFIG_FILE: &str = ".oxlintrc.json";
 
-// max range for LSP integer is 2^31 - 1
-// https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#baseTypes
-const LSP_MAX_INT: u32 = 2u32.pow(31) - 1;
-
 #[tokio::main]
 async fn main() {
     env_logger::init();

crates/oxc_language_server/src/snapshots/fixtures_linter_issue_9958@issue.ts.snap

@@ -56,7 +56,7 @@ fixed: Multiple(
 code: "typescript-eslint(no-non-null-asserted-optional-chain)"
 code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-non-null-asserted-optional-chain.html"
 message: "Optional chain expressions can return undefined by design: using a non-null assertion is unsafe and wrong.\nhelp: Remove the non-null assertion."
-range: Range { start: Position { line: 11, character: 18 }, end: Position { line: 11, character: 19 } }
+range: Range { start: Position { line: 11, character: 21 }, end: Position { line: 11, character: 22 } }
 related_information[0].message: "non-null assertion made after optional chain"
 related_information[0].location.uri: "file://<variable>/fixtures/linter/issue_9958/issue.ts"
 related_information[0].location.range: Range { start: Position { line: 11, character: 21 }, end: Position { line: 11, character: 22 } }
@@ -106,11 +106,11 @@ fixed: Multiple(
 
 code: "None"
 code_description.href: "None"
-message: "non-null assertion made after optional chain"
-range: Range { start: Position { line: 11, character: 21 }, end: Position { line: 11, character: 22 } }
+message: "optional chain used"
+range: Range { start: Position { line: 11, character: 18 }, end: Position { line: 11, character: 19 } }
 related_information[0].message: "original diagnostic"
 related_information[0].location.uri: "file://<variable>/fixtures/linter/issue_9958/issue.ts"
-related_information[0].location.range: Range { start: Position { line: 11, character: 18 }, end: Position { line: 11, character: 19 } }
+related_information[0].location.range: Range { start: Position { line: 11, character: 21 }, end: Position { line: 11, character: 22 } }
 severity: Some(Hint)
 source: Some("oxc")
 tags: None