feat(linter/plugins): remove --js-plugins CLI option

Author: overlookmotel

apps/oxlint/src/command/lint.rs

@@ -50,10 +50,6 @@ pub struct LintCommand {
     #[bpaf(switch, hide_usage)]
     pub type_aware: bool,
 
-    /// Enables JS plugins (experimental).
-    #[bpaf(switch, hide)]
-    pub js_plugins: bool,
-
     #[bpaf(external)]
     pub inline_config_options: InlineConfigOptions,
 

apps/oxlint/src/lint.rs

@@ -238,6 +238,14 @@ impl CliRunner {
         let mut external_linter = self.external_linter;
         if external_plugin_store.is_empty() {
             external_linter = None;
+        } else {
+            #[cfg(not(any(test, feature = "force_test_reporter")))]
+            #[expect(clippy::print_stderr)]
+            {
+                eprintln!(
+                    "WARNING: JS plugins are experimental and not subject to semver.\nBreaking changes are possible while JS plugins are under development."
+                );
+            }
         }
 
         if let Some(basic_config_file) = oxlintrc_for_print {

apps/oxlint/src/run.rs

@@ -86,23 +86,12 @@ fn lint_impl(load_plugin: JsLoadPluginCb, lint_file: JsLintFileCb) -> CliRunResu
 
     command.handle_threads();
 
-    let external_linter = if command.js_plugins {
-        // JS plugins are only supported on 64-bit little-endian platforms at present
-        #[cfg(all(target_pointer_width = "64", target_endian = "little"))]
-        {
-            Some(super::js_plugins::create_external_linter(load_plugin, lint_file))
-        }
-
-        #[cfg(not(all(target_pointer_width = "64", target_endian = "little")))]
-        #[expect(clippy::print_stderr)]
-        {
-            let (_, _) = (load_plugin, lint_file);
-            eprintln!(
-                "ERROR: JS plugins are only supported on 64-bit little-endian platforms at present"
-            );
-            return CliRunResult::InvalidOptionConfig;
-        }
-    } else {
+    // JS plugins are only supported on 64-bit little-endian platforms at present
+    #[cfg(all(target_pointer_width = "64", target_endian = "little"))]
+    let external_linter = Some(super::js_plugins::create_external_linter(load_plugin, lint_file));
+    #[cfg(not(all(target_pointer_width = "64", target_endian = "little")))]
+    let external_linter = {
+        let (_, _) = (load_plugin, lint_file);
         None
     };
 

apps/oxlint/test/e2e.test.ts

@@ -8,7 +8,6 @@ const CLI_PATH = pathJoin(PACKAGE_ROOT_PATH, 'dist/cli.js');
 // Options to pass to `testFixture`.
 interface TestOptions {
   // Arguments to pass to the CLI.
-  // Defaults to `['--js-plugins']`.
   args?: string[];
   // Name of the snapshot file.
   // Defaults to `output`.
@@ -24,7 +23,7 @@ interface TestOptions {
  * @param options - Options to customize the test (optional)
  */
 async function testFixture(fixtureName: string, options?: TestOptions): Promise<void> {
-  const args = options?.args ?? ['--js-plugins'];
+  const args = options?.args ?? [];
 
   await testFixtureWithCommand({
     command: 'node',
@@ -36,24 +35,16 @@ async function testFixture(fixtureName: string, options?: TestOptions): Promise<
 }
 
 describe('oxlint CLI', () => {
-  it('should lint a directory without errors without JS plugins enabled', async () => {
-    await testFixture('built_in_no_errors', { args: [], snapshotName: 'plugins_disabled' });
+  it('should lint a directory without errors', async () => {
+    await testFixture('built_in_no_errors', { args: [] });
   });
 
-  it('should lint a directory with errors without JS plugins enabled', async () => {
-    await testFixture('built_in_errors', { args: [], snapshotName: 'plugins_disabled' });
-  });
-
-  it('should lint a directory without errors with JS plugins enabled', async () => {
-    await testFixture('built_in_no_errors', { snapshotName: 'plugins_enabled' });
-  });
-
-  it('should lint a directory with errors with JS plugins enabled', async () => {
-    await testFixture('built_in_errors', { snapshotName: 'plugins_enabled' });
+  it('should lint a directory with errors', async () => {
+    await testFixture('built_in_errors', { args: [] });
   });
 
   it('should load a custom plugin', async () => {
-    await testFixture('basic_custom_plugin', { snapshotName: 'plugins_enabled' });
+    await testFixture('basic_custom_plugin');
   });
 
   it('should load a custom plugin with various import styles', async () => {
@@ -68,10 +59,6 @@ describe('oxlint CLI', () => {
     await testFixture('custom_plugin_via_overrides');
   });
 
-  it('should report an error if a custom plugin in config but JS plugins are not enabled', async () => {
-    await testFixture('basic_custom_plugin', { args: [], snapshotName: 'plugins_disabled' });
-  });
-
   it('should report an error if a custom plugin is missing', async () => {
     await testFixture('missing_custom_plugin');
   });
@@ -171,7 +158,7 @@ describe('oxlint CLI', () => {
 
     try {
       await testFixture('fixes', {
-        args: ['--js-plugins', '--fix'],
+        args: ['--fix'],
         snapshotName: 'fixes_enabled',
         async getExtraSnapshotData() {
           const codeAfter = await fs.readFile(fixtureFilePath, 'utf8');