feat(linter): add fix for preserve-caught-error

Author: camchenry

crates/oxc_linter/src/rules/eslint/preserve_caught_error.rs

@@ -14,17 +14,19 @@ use serde::{Deserialize, Serialize};
 use crate::{AstNode, context::LintContext, rule::Rule};
 
 fn preserve_caught_error_diagnostic(span: Span) -> OxcDiagnostic {
-    OxcDiagnostic::warn("preserve-caught-error")
+    OxcDiagnostic::warn("There is no cause error attached to this new thrown error.")
         .with_help(
-            "When re-throwing an error, preserve the original error using the 'cause' property",
+            "Preserve the original error by using the `cause` property when re-throwing errors.",
         )
         .with_label(span)
 }
 
 fn missing_catch_parameter_diagnostic(span: Span) -> OxcDiagnostic {
-    OxcDiagnostic::warn("preserve-caught-error")
-        .with_help("Catch clause must have a parameter when 'requireCatchParameter' is enabled")
-        .with_label(span)
+    OxcDiagnostic::warn(
+        "The caught error is not accessible because the catch clause has no error parameter.",
+    )
+    .with_help("Add an error parameter to the catch clause to access the caught error.")
+    .with_label(span)
 }
 
 #[derive(Debug, Default, Clone, Serialize, Deserialize, JsonSchema)]
@@ -66,7 +68,18 @@ impl<'a> Visit<'a> for ThrowFinder<'a, '_> {
             return;
         }
 
-        self.ctx.diagnostic(preserve_caught_error_diagnostic(throw_stmt.span));
+        if args.len() == 1
+            && let Some(ident) = self.catch_param.get_identifier_name()
+        {
+            self.ctx.diagnostic_with_fix(
+                preserve_caught_error_diagnostic(throw_stmt.span),
+                |fixer| {
+                    fixer.insert_text_after(&args[0], format!(", {{ cause: {} }}", ident.as_str()))
+                },
+            );
+        } else {
+            self.ctx.diagnostic(preserve_caught_error_diagnostic(throw_stmt.span));
+        }
     }
 
     // Do not traverse into nested functions/closures within the catch block
@@ -162,7 +175,7 @@ declare_oxc_lint!(
     PreserveCaughtError,
     eslint,
     suspicious,
-    pending,
+    conditional_fix,
     config = PreserveCaughtErrorOptions,
 );
 impl PreserveCaughtError {
@@ -544,6 +557,62 @@ fn test() {
         ),
     ];
 
+    let fix = vec![
+        (
+            r#"try {
+                        doSomething();
+                    } catch (err) {
+                        throw new Error("Something failed");
+                    }"#,
+            r#"try {
+                        doSomething();
+                    } catch (err) {
+                        throw new Error("Something failed", { cause: err });
+                    }"#,
+            None,
+        ),
+        (
+            r#"try {
+                        doSomething();
+                    } catch (error) {
+                        throw new Error("Failed");
+                    }"#,
+            r#"try {
+                        doSomething();
+                    } catch (error) {
+                        throw new Error("Failed", { cause: error });
+                    }"#,
+            None,
+        ),
+        (
+            r#"try {
+                        doSomething();
+                    } catch (error) {
+                        throw new Error("Failed", { existingOption: true });
+                    }"#,
+            r#"try {
+                        doSomething();
+                    } catch (error) {
+                        throw new Error("Failed", { existingOption: true, cause: error });
+                    }"#,
+            None,
+        ),
+        (
+            r#"try {
+                        doSomething();
+                    } catch (err) {
+                        throw new Error("Something failed", {});
+                    }"#,
+            r#"try {
+                        doSomething();
+                    } catch (err) {
+                        throw new Error("Something failed", { cause: err });
+                    }"#,
+            None,
+        ),
+    ];
+
     Tester::new(PreserveCaughtError::NAME, PreserveCaughtError::PLUGIN, pass, fail)
+        .expect_fix(fix)
         .test_and_snapshot();
 }