spread immediately ran the deserializer, make it actually lazy this time

Author: lilnasy

apps/oxlint/src-js/generated/deserialize.js

@@ -31,13 +31,7 @@ function deserializeWith(buffer, sourceTextInput, sourceByteLenInput, getLocInpu
   sourceByteLen = sourceByteLenInput;
   sourceIsAscii = sourceText.length === sourceByteLen;
   getLoc = getLocInput;
-  let data = deserialize(uint32[536870902]);
-  uint8 =
-    uint32 =
-    float64 =
-    sourceText =
-      void 0;
-  return data;
+  return deserialize(uint32[536870902]);
 }
 
 function deserializeProgram(pos) {
@@ -48,18 +42,24 @@ function deserializeProgram(pos) {
       body: null,
       sourceType: deserializeModuleKind(pos + 125),
       hashbang: null,
-      ...{
-        get comments() {
-          let c = deserializeVecComment(pos + 24);
-          Object.defineProperty(this, 'comments', { value: c });
-          return c;
-        },
-      },
       start: 0,
       end,
       range: [0, end],
       parent: null,
     };
+  Object.defineProperty(program, 'comments', {
+    configurable: true,
+    get() {
+      let c = deserializeVecComment(pos + 24);
+      uint8 =
+        uint32 =
+        float64 =
+        sourceText =
+          void 0;
+      Object.defineProperty(this, 'comments', { value: c });
+      return c;
+    },
+  });
   program.hashbang = deserializeOptionHashbang(pos + 48);
   let body = program.body = deserializeVecDirective(pos + 72);
   body.push(...deserializeVecStatement(pos + 96));

crates/oxc_ast/src/serialize/mod.rs

@@ -129,19 +129,24 @@ impl Program<'_> {
         body: null,
         sourceType: DESER[ModuleKind](POS_OFFSET.source_type.module_kind),
         hashbang: null,
-        ...(COMMENTS && {
-            get comments() {
-                const c = DESER[Vec<Comment>](POS_OFFSET.comments);
-                Object.defineProperty(this, 'comments', { value: c });
-                return c;
-            }
-        }),
         start,
         end,
         ...(RANGE && { range: [start, end] }),
         ...(PARENT && { parent: null }),
     };
 
+    if (COMMENTS) {
+        Object.defineProperty(program, 'comments', {
+            configurable: true,
+            get() {
+                const c = DESER[Vec<Comment>](POS_OFFSET.comments);
+                uint8 = uint32 = float64 = sourceText = undefined;
+                Object.defineProperty(this, 'comments', { value: c });
+                return c;
+            }
+        })
+    }
+
     program.hashbang = DESER[Option<Hashbang>](POS_OFFSET.hashbang);
 
     const body = program.body = DESER[Vec<Directive>](POS_OFFSET.directives);

tasks/ast_tools/src/generators/raw_transfer.rs

@@ -173,6 +173,7 @@ fn generate_deserializers(
 
             const data = deserialize(uint32[{data_pointer_pos_32}]);
 
+            if (!COMMENTS)
             uint8 = uint32 = float64 = sourceText = undefined;
 
             return data;