perf(linter): no-unused-private-class-members: only run when there are any classes (#14869)

camchenry · camchenry · commit 11b055e6903b · 2025-10-22T08:19:26.000Z
Same story as #14865. Initial codspeed benchmark showed an anomalously large drop, though I'm not sure why. I'd expect a measurable but very small improvement.
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_private_class_members.rs b/crates/oxc_linter/src/rules/eslint/no_unused_private_class_members.rs
@@ -111,6 +111,10 @@ impl Rule for NoUnusedPrivateClassMembers {
             }
         });
     }
+
+    fn should_run(&self, ctx: &crate::context::ContextHost) -> bool {
+        ctx.semantic().classes().len() > 0
+    }
 }
 
 fn is_read(current_node_id: NodeId, semantic: &Semantic) -> bool {

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,10 @@ impl Rule for NoUnusedPrivateClassMembers {`
`111`	`111`	`}`
`112`	`112`	`});`
`113`	`113`	`}`
	`114`	`+`
	`115`	`+ fn should_run(&self, ctx: &crate::context::ContextHost) -> bool {`
	`116`	`+ ctx.semantic().classes().len() > 0`
	`117`	`+ }`
`114`	`118`	`}`
`115`	`119`
`116`	`120`	`fn is_read(current_node_id: NodeId, semantic: &Semantic) -> bool {`