refs #434 workaround in webpack-dev-server #436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
approved these changes
Dec 24, 2018
|
superseded by #441 |
diocas
pushed a commit
to cernbox/web
that referenced
this pull request
Mar 31, 2025
chore(deps): update pnpm to v10.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#434
webpack/webpack-dev-server@1dfd4fb
webpack/webpack-dev-server#1604
sockjs/sockjs-node#247
Motivation and Context
I've merged #434, but it may flood your console with error messages if you use custom
SERVER_HOST.I feel responsible for repairing this issue, but it depend's on changes in webpack-dev-server, which in turn depend's on some changes in sockjs. I've taken a short look at this, but they are refactoring hard & i do miss much context from the sockjs community.
So the best way seem's to disable the broken host check at this moment.
That's what i've done here.
How Has This Been Tested?
SERVER_HOSTTypes of changes
Checklist: