Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy API testinfrastructure to ocis repository #5094

Closed
individual-it opened this issue Nov 22, 2022 · 6 comments
Closed

copy API testinfrastructure to ocis repository #5094

individual-it opened this issue Nov 22, 2022 · 6 comments
Assignees

Comments

@individual-it
Copy link
Member

individual-it commented Nov 22, 2022

To make it easier to administer different oCIS branches and the respected tests it might be better to copy all the test-infrastructure from the core repository to oCIS.
This should reduce the dependencies between repositories and the work to bump the commit ids, but if changes are needed in oc10 it might increase the effort. But oc10 changes should not happen much in the future.

@individual-it
Copy link
Member Author

CC @micbar

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Dec 28, 2022

@individual-it @phil-davis @micbar With #5280, just the tests infrastructures are copied. Now the local API tests are independent with oC/core but the oCIS CI still depends on oC/core repository to run core API tests and will be necessary to run parallel deployment tests (which needs OccContexts and testing app like things) if we enable it.

more analysis here #5280 (comment)

@phil-davis
Copy link
Contributor

"copy all the test-infrastructure from the core repository to oCIS"

@individual-it I just want to clarify what "all" means:

  • test helpers code
  • test code (that is found in tests/acceptance/features/bootstrap)
  • test scripts (like run.sh and lint scripts...
  • API acceptance test feature files that are currently in oC10 core

And after this issue is done, the ocis CI will not need to fetch the core oC10 repo at all.

@phil-davis
Copy link
Contributor

"parallel deployment tests" - hmmm, we will need to think about how we support those.

The drone script in ocis CI can still know how to install an oC10 and set the needed env vars etc to get the parallel deployment installed and working.

Then we will need to look at what test scenarios that we really want to run against a parallel deployment. If we really need to change oC10 settings/options at test startup, or scenario Given steps, then we will need to make the CI have the testing app installed in oC10, and copy the needed OccConext etc code into ocis so that it can be used.

@saw-jan
Copy link
Member

saw-jan commented Jan 5, 2023

IMO, this can be closed and we can open new issue for clean up tasks

CC @phil-davis @individual-it

@saw-jan
Copy link
Member

saw-jan commented Jan 5, 2023

Task has been completed. Create cleanup issue #5337
So, closing here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants