Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Experimental VFS not available in branded mac builds #53

Open
2 tasks done
HanaGemela opened this issue Feb 6, 2023 · 5 comments
Open
2 tasks done

[QA] Experimental VFS not available in branded mac builds #53

HanaGemela opened this issue Feb 6, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@HanaGemela
Copy link

HanaGemela commented Feb 6, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

Experimental VFS not available in branded mac builds
Client 3.1.0 https://cloud.owncloud.com/index.php/f/5962228

Steps to reproduce the issue

  1. Build a branded client with:
    VFS - yes
    Enforce virtual files - yes

  2. Check the availability of VFS

Screenshots

No screenshots

Expected behavior

Experimental feature is available

Actual behavior

Experimental feature is not available

@HanaGemela HanaGemela added the bug Something isn't working label Feb 6, 2023
@michaelstingl
Copy link
Contributor

Experimental features not available in branded builds (except testpilotcloud)

@michaelstingl michaelstingl transferred this issue from owncloud/client Feb 6, 2023
@HanaGemela
Copy link
Author

How come testpilotcloud has it? What settings is it?

@michaelstingl
Copy link
Contributor

How come testpilotcloud has it? What settings is it?

@fmoc point to code?

@fmoc
Copy link

fmoc commented Feb 6, 2023

It's bool enableExperimentalFeatures() const in theme.h, see https://github.com/owncloud/client/blob/master/src/libsync/theme.h#L424-L430. This method's behavior cannot be configured from ownbrander. For testpilotcloud, the method has been overwritten to explicitly return true.

@michaelstingl
Copy link
Contributor

Yes, experimental features should be never ever be enabled in branded builds, except testpilotcloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants