Use a capped memory cache for the user/group cache #24869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @blizzz, @leo-b and @alexweirig to be potential reviewers |
For #24403 When upgrading huge installations this can lead to memory problems as the cache will only grow and grow. Capping this memory will make sure we don't run out while during normal operation still basically cache everything.
DeepDiver1975
force-pushed
the
ldap_capped_cache
branch
from
259906c
to
dc4fd43
Compare
|
@owncloud/ldap |
|
Found #24888 while testing |
|
Looks fine 👍 |
|
@nickvergessen second review ? |
|
Hmm I thought I already commented here yesterday... |
|
Backport down to 8.2 if possible ? @rullzer @cmonteroluque @DeepDiver1975 @butonic |
|
Yes will take care |
This was referenced Jun 1, 2016
|
Thanks @rullzer |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #24403
When upgrading huge installations this can lead to memory problems as
the cache will only grow and grow.
Capping this memory will make sure we don't run out while during normal
operation still basically cache everything.
CC: @blizzz @PVince81 @MorrisJobke