Skip to content

document front_controller_active #14813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MorrisJobke wants to merge 1 commit into from
Closed

document front_controller_active #14813

MorrisJobke wants to merge 1 commit into from

Conversation

@MorrisJobke
Copy link
Contributor

@MorrisJobke MorrisJobke commented Mar 11, 2015

cc @DeepDiver1975 @LukasReschke

I need your help regarding the webserver config. Because we have apps/files/index.php the simple FallbackResource doesn't trigger very well. I guess we need to adjust RewriteRules.

fixes #12345 once it is done

@MorrisJobke MorrisJobke added this to the 8.1-current milestone Mar 11, 2015
@scrutinizer-notifier
Copy link

scrutinizer-notifier commented Mar 11, 2015

The inspection completed: No new issues

@nickvergessen
Copy link
Contributor

nickvergessen commented Mar 12, 2015

Failing avatar tests 🙈

@nickvergessen nickvergessen mentioned this pull request Mar 12, 2015
Closed
@MorrisJobke
Copy link
Contributor Author

MorrisJobke commented Mar 12, 2015

fixed on master

@ghost
Copy link

ghost commented Mar 12, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10382/
Test PASSed.

DeepDiver1975
DeepDiver1975 reviewed Mar 12, 2015
View reviewed changes
.htaccess
Copy link
Member

@DeepDiver1975 DeepDiver1975 Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against this change - I tried to get owncloud properly running using FallbackResource and this did not really work out.

Copy link
Member

@LukasReschke LukasReschke Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - that will very likely cause problems. We really need some blackmagic such as https://github.com/owncloud/core/pull/14081/files#diff-8052c42ab3b8aa06a3f5f788a4ddccc2R52

Copy link
Contributor Author

@MorrisJobke MorrisJobke Mar 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry ... I didn't want to commit that initially ... this should just show what I tried.

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Mar 12, 2015

refs #14081

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Mar 12, 2015

refs #14081

@MorrisJobke I'd rather go for #14081

@MorrisJobke MorrisJobke deleted the document-front_controller_active branch March 12, 2015 11:41
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

2 - Developing

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

Document front_controller_active in config.sample.php

6 participants

@MorrisJobke @scrutinizer-notifier @nickvergessen @DeepDiver1975 @LukasReschke