Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling of CRUDs methods #32497

Open
phil-davis opened this issue Aug 29, 2018 · 0 comments
Open

Spelling of CRUDs methods #32497

phil-davis opened this issue Aug 29, 2018 · 0 comments

Comments

@phil-davis
Copy link
Contributor

public function isCreatable($path) {

In here (and other places) there are methods:

isCreatable()
isUpdatable()
isDeletable()
isSharable()

In other places there are methods:

isUpdateable()
isShareable()

and I guess there is potential for:

isCreateable()
isDeleteable()

Creatable and Deletable seem to be accepted English spelling.

Is there any likely problem here with method names and inheritance, where someone might think they are overriding a method in a parent class, but the spelling is different, so actually they have actually added a new method? Or?

@PVince81 PVince81 added this to the backlog milestone Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants