Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity/event list for files in right sidebar #18164

Closed
PVince81 opened this issue Aug 10, 2015 · 7 comments
Closed

Activity/event list for files in right sidebar #18164

PVince81 opened this issue Aug 10, 2015 · 7 comments

Comments

@PVince81
Copy link
Contributor

Before we can show comments or versions inline, we need the groundwork to be done, which is the ability to display a list of events/activities inside a panel.

An event can be one of:

The API needs to be generic enough for such apps to be able to embed their rows into the list.

@jancborchardt @nickvergessen @schiesbn @DeepDiver1975

I'll have a go at the generic interface/API on the Javascript side.

The question is whether we want a PHP-side API (app framework) that can deliver all events in one go or do we want each event type to be retrieved separately. Each approach has its own challenges.

@nickvergessen we probably need something similar to the activity manager where apps can push events. Or should we reuse the activity manager / activities as a base for all this ?

@jancborchardt
Copy link
Member

Keep in mind this is something we most likely want to display in the mobile and desktop clients as well somehow. So it needs to be generic and performant.

@PVince81
Copy link
Contributor Author

Mock up here: #16308 (comment)

Or is there anything more recent ?

@jancborchardt
Copy link
Member

That’s still the spec and the current plan.

@karlitschek
Copy link
Contributor

I think this is the most recent one. It's still an open question if we really want to mix the activities with comments and version. I think it is a neat idea but could totally kill the clearness and makes old versions impossible to find. I suggest to start with notmal activities first.

@jancborchardt
Copy link
Member

We’ll do it step by step of course, but the comments, version and activity should all be mixed of course. It’s one chronological list.

@PVince81
Copy link
Contributor Author

Activity tab WIP PR here: owncloud/activity#358

@nickvergessen
Copy link
Contributor

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants