Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move share dropdown into the right sidebar in the files app #17665

Closed
6 of 8 tasks
PVince81 opened this issue Jul 15, 2015 · 3 comments
Closed
6 of 8 tasks

Move share dropdown into the right sidebar in the files app #17665

PVince81 opened this issue Jul 15, 2015 · 3 comments

Comments

@PVince81
Copy link
Contributor

The share dropdown is implemented in core in OC.Share.showDropdown() and all related events and functions.

This is how to proceed:

  • implement ShareTabView which will be a tab in the right sidebar (see Basic work for right sidebar #17656), a stub is provided there
  • implement each section of the share dialog as separate classes
    • sharing with local users as one panel (View class)
    • sharing with link as the second panel (View class)
  • write a class to manage shares, maybe OC.Sharing.Client (similar to OC.Files.Client here https://github.com/owncloud/core/pull/16902/files?w=1#diff-a6f5f0ecc4845f72e7fe0908a1f90f70R26)
    • this class must wrap the OCS Share API calls in convenient functions (even if we decide to keep using the old endpoints)
    • make use of the OCS Share API endpoints (see webUI to OCS Share API #17143)
    • this class will be used by the view classes when accessing shares
    • the alternative would be to use Model classes, and have the ajax logic there
  • use handlebars for the templates (templates as hard-coded strings in the JS code for now to make them unit-testable)
  • add JS unit tests for all these classes
  • once the ShareTabView is merged, discuss/think whether to remove the old OC.Share.showDropDown in regards to other apps that might still be using it

@rullzer @blizzz @DeepDiver1975

@PVince81
Copy link
Contributor Author

While doing so, also have a look at this slightly redesigned mock up, which could be implemented by the same occasion.

This was referenced Jul 15, 2015
@PVince81 PVince81 added this to the 8.2-current milestone Jul 27, 2015
@PVince81
Copy link
Contributor Author

As discussed with @rullzer and @DeepDiver1975, we will move the old OC.Share.showDropdown to the calendar and contacts apps respectively, to make sure they can still use the old dropdown as before.

@PVince81
Copy link
Contributor Author

Fixing the apps is tracked here: #19214

This task is done. Note that it wasn't implemented 100% as described above

OCS endpoints will be implemented as per #17143

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant