-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a thumbnail/grid view to the Files app #17357
Comments
I do agree with the basic point, however I’m still not sure if it’s a good idea to introduce a third view. It will be a maintenance nightmare on top of what we already have, and I kinda doubt the benefit over the Gallery, since you will just see a bunch of big filetype icons on top of what the Gallery would already show. |
I don't think the 2nd view exists. It's another app, with a different purpose.
There are lots of reusable components such as panels, thumbnails, actions. Only the UI changes. |
I totally agree, the current behaviour is misleading. I am reposting my original issue "When in File view, when I switch from list to grid view, folders disappear owncloud/gallery#462" here: When I am viewing a list of folders in list view and swith to grid view, only the folders with only photos in them will stay visible, other folders disappear. User is not consciously choosing the Gallery app, in his/her mind he is only swithing the view on existing files. Current behaviour makes it seem that foldders suddenly go missing. Expected behaviour: |
Setting as to be discussed for 9.1 |
This is part of the GSOC 2016 and someone has already taken an interest. Since Files is not my speciality, I think someone other than me should be handling the project. @PVince81? @MorrisJobke? @rullzer? |
I don't think we should add a grid view to the files app in core. Alternatively it would have to be a plugin system with buttons in the controls bar (or another way of switching) where apps can provide their own file list views for all existing views. |
This would require some extension points in core to make it possible for apps to register such views on the JS side. |
OK, so just like for the sidebar, add a plugin system to that central column in Files and create That's more work than simply changing CSS classes at the flick of a button to present the information differently, but would be more useful in the long run. |
Thinking about this some more, being able to completely replace the table full of rows with a different view would open a world of possibilities in terms of files+data visualisation. The photowall from gallery could be implemented directly in Files as an alternative view, you could have a virtual earth view, clever colour coded mapping based on meta data, etc. |
I dream of something like that! |
@PVince81 how much work is it to introduce the plugin system? We don't want GSoC students to work in core due to the known issues. |
It depends how much of the existing code we want to be reusable. The Maybe we can find a compromise where we only provide the UI elements to switch views (to be designed), and app implementers will have to rewrite their own FileList logic from scratch using |
So this is a critical decision point regarding the GSoC application - if we cannot come up with a plugin system before the student actually can start working the project idea should be removed from the GSoC page - https://github.com/owncloud/core/wiki/Google-Summer-of-Code#2016--current |
Let's remove this from the list. Too much core interference for a great GSoC project. |
Alternative approach which might be easier and whatever work is done there will be needed anyway for the grid view: provide the gallery app as a files app section owncloud/gallery#727 One drawback of this is only that the gallery is its own file list instead of providing the ability to switch any file view (ex: trashbin) to thumbnail mode. But as said above, doing the work to have it be a separate files app section already brings us closer to that goal. |
friendly bump |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed. |
Every files manager has more than one view. The current list view doesn't fill all use cases, some people will prefer to have a detailed view while others will want to see large visual representations of their files.
You might think that Gallery is the Files' thumbnail view, but that's wrong. Gallery will not show all possible media types and focuses on visual media. It's currently being misused as a poor man's thumbnails view for files.
So, it's high time the Files app introduces its thumbnails view.
Next steps
@jancborchardt , as discussed
Input welcome: @DeepDiver1975 @PVince81 @georgehrke @LukasReschke @BernhardPosselt @schiesbn @nickvergessen @libasys @deMattin @setnes
The text was updated successfully, but these errors were encountered: