Merge pull request #24392 from owncloud/declare-cron-jobs-in-info.xml

Declare cron jobs in info.xml

Author: DeepDiver1975

apps/dav/appinfo/application.php

@@ -153,11 +153,6 @@ public function getSyncService() {
 		return $this->getContainer()->query('SyncService');
 	}
 
-	public function setupCron() {
-		$jl = $this->getContainer()->getServer()->getJobList();
-		$jl->add(new SyncJob());
-	}
-
 	public function generateBirthdays() {
 		try {
 			/** @var BirthdayService $migration */

apps/dav/appinfo/info.xml

@@ -16,4 +16,7 @@
 	<dependencies>
 		<owncloud min-version="9.1" max-version="9.1" />
 	</dependencies>
+	<background-jobs>
+		<job>OCA\DAV\CardDAV\Sync\SyncJob</job>
+	</background-jobs>
 </info>

apps/dav/appinfo/install.php

@@ -22,5 +22,4 @@
 use OCA\Dav\AppInfo\Application;
 
 $app = new Application();
-$app->setupCron();
 $app->generateBirthdays();

apps/dav/appinfo/update.php

@@ -22,5 +22,4 @@
 use OCA\Dav\AppInfo\Application;
 
 $app = new Application();
-$app->setupCron();
 $app->generateBirthdays();

lib/private/App/InfoParser.php

@@ -89,6 +89,9 @@ public function parse($file) {
 		if (!array_key_exists('uninstall', $array['repair-steps'])) {
 			$array['repair-steps']['uninstall'] = [];
 		}
+		if (!array_key_exists('background-jobs', $array)) {
+			$array['background-jobs'] = [];
+		}
 
 		if (array_key_exists('documentation', $array) && is_array($array['documentation'])) {
 			foreach ($array['documentation'] as $key => $url) {
@@ -128,6 +131,9 @@ public function parse($file) {
 		if (isset($array['repair-steps']['uninstall']['step']) && is_array($array['repair-steps']['uninstall']['step'])) {
 			$array['repair-steps']['uninstall'] = $array['repair-steps']['uninstall']['step'];
 		}
+		if (isset($array['background-jobs']['job']) && is_array($array['background-jobs']['job'])) {
+			$array['background-jobs'] = $array['background-jobs']['job'];
+		}
 		return $array;
 	}
 
@@ -147,10 +153,7 @@ function xmlToArray($xml) {
 			if (!isset($array[$element])) {
 				$array[$element] = "";
 			}
-			/**
-			 * @var \SimpleXMLElement $node
-			 */
-
+			/** @var \SimpleXMLElement $node */
 			// Has attributes
 			if ($attributes = $node->attributes()) {
 				$data = [

lib/private/Installer.php

@@ -133,6 +133,8 @@ public static function installApp( $data = array()) {
 			}
 		}
 
+		\OC_App::setupBackgroundJobs($info['background-jobs']);
+
 		//run appinfo/install.php
 		if((!isset($data['noinstall']) or $data['noinstall']==false)) {
 			self::includeAppScript($basedir . '/appinfo/install.php');
@@ -569,6 +571,7 @@ public static function installShippedApp($app) {
 		if (is_null($info)) {
 			return false;
 		}
+		\OC_App::setupBackgroundJobs($info['background-jobs']);
 
 		OC_App::executeRepairSteps($app, $info['repair-steps']['install']);
 

lib/private/legacy/app.php

@@ -1190,6 +1190,7 @@ public static function updateApp($appId) {
 			self::loadApp($appId, false);
 			include $appPath . '/appinfo/update.php';
 		}
+		self::setupBackgroundJobs($appData['background-jobs']);
 
 		//set remote/public handlers
 		if (array_key_exists('ocsid', $appData)) {
@@ -1240,6 +1241,13 @@ public static function executeRepairSteps($appId, array $steps) {
 		$r->run();
 	}
 
+	public static function setupBackgroundJobs(array $jobs) {
+		$queue = \OC::$server->getJobList();
+		foreach ($jobs as $job) {
+			$queue->add($job);
+		}
+	}
+
 	/**
 	 * @param string $appId
 	 * @param string[] $steps

tests/data/app/expected-info.json

@@ -74,5 +74,6 @@
 		"post-migration": [],
 		"live-migration": [],
 		"uninstall": []
-	}
+	},
+	"background-jobs": []
 }