Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branding] Extend Theme::overrideServerUrl() to allow a list of predefined URLs #6494

Open
SamuAlfageme opened this issue Apr 26, 2018 · 4 comments

Comments

@SamuAlfageme
Copy link
Contributor

There's this one use-case where an organization might have multiple ownCloud instances for different aspects/departments: to keep things semantically separated, see them as independent services, etc.

The multi-account support on the client allows users to sync from various locations with the same client. However, companies normally need something in the middle: flexible to add more than one account but restricted to their internal instances.

Instead of providing one branded client with a predefined URL for each of these instances, It'd be much more powerful to allow the user to select one from a list at account-creation time. I made some mockups to throw some light on how this could look like:

With Headings Just the URL
headings list

This list of URLs would be fetched from ownBrander (we'll require to do something similar for the iOS app in the near future: https://github.com/owncloud/ownbrander/issues/769):

{
	"Internal ownCloud": "https://cloud.company.xyz",
	"Sales ownCloud": "https://sales.company.xyz",
	"Customers ownCloud": "https://customers.company.xyz"
}

... and fit in the generated *-theme.h.

Also, consider greying-out / disabling those unreachable URLs when facing the selection:

cc/ @michaelstingl - we discussed this one last time in NUE - maybe it also makes sense for the rest of the platform?

@guruz
Copy link
Contributor

guruz commented Apr 26, 2018

(For the record: We also have/had a feature where there is a lookup/mapping from username->oC_URL.
However that might not be good here as one would have the same username on all thos instances)

@ogoffart
Copy link
Contributor

What would be easy to do would be to replace the lineedit in which one need to enter the URL, with a combobox.
We could need a new Theme::predefinedServerUrl() which returns a QStringList. Or a list of a pair with a Url, and a better description (but this can be a problem for translations)

Having push buttons, or radio buttons would be possible too.

@guruz guruz added this to the 2.6.0 milestone May 30, 2018
@ogoffart
Copy link
Contributor

ogoffart commented Dec 4, 2018

@pmaier1 Is this still something that needs to be done?

@michaelstingl
Copy link
Contributor

no priority for now

@ogoffart ogoffart removed this from the 2.6.0 milestone Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants