Remove Database Cleaner and share FactoryBot factories

[texpert]

Threads sharing a DB connection has been fixed in Rails 5.1 by Rails team and Capybara author, so Database Cleaner can be removed.

Changes:

• database_cleaner gem removed and all its calls from the rails_helper hooks
• config.use_transactional_fixtures set to true
• factory_bot gem replaced by the factory_bot_rails
• Fetching factories into FactoryBot.definition_file_paths is defined in the CamaleonCMS::Engine, thus sharing the factories from the camaleon_cms gem with the main application
• config.serve_static_files replaced by config.public_file_server.enabled (a change from Rails 5.1 also)
• Capybara::Webkit is no longer used, so removed the related code from the spec_helper
• The favicon added into the dummy's public, because the captcha specs started failing on GET /favicon requests.
• The init_site method from spec/support/common.rb has been slightly refactored to call CamaleonCms::Site.delete_all before every test run, and to nullify the @site, @post ivars, as well as the CamaleonCMS::Site class ivar @main_site. The latter being a class ivar has been persisting through all the specs, causing failures
• Due to database_cleaner removal, the DB now is not cleaned entirely after every test, so the Site associations like posts, post_types, categories, etc., have been refactored to be dynamically fetched as @site associations.
  • This could be better refactored in the future. Particularily the site factory slug should be made rendom to not cause validation issues, after which the CamaleonCms::Site.delete_all before each test will be possible to remove, and the @site and @post ivars refactored to RSpec let memoizers.

[brian-kephart]

@texpert This looks awesome! Thanks, I didn't realize the transaction issue was fixed. One more dependency down, and a bunch of config removed! Plus, the tests for edge Rails are working again.

I'm curious, why does the diff show a change to the dummy app's favicon?

[texpert]

@texpert This looks awesome! Thanks, I didn't realize the transaction issue was fixed. One more dependency down, and a bunch of config removed! Plus, the tests for edge Rails are working again.

I'm curious, why does the diff show a change to the dummy app's favicon?

Oh, I had to add the favicon into the dummy's public, because the captcha specs started failing on GET /favicon requests.

Yeah, I am also, like you, always glad to remove some dependencies :)