fixed bug in edge case of using Union with dict

Author: DinisCruz

osbot_utils/type_safe/type_safe_core/steps/Type_Safe__Step__Init.py

@@ -1,4 +1,4 @@
-from typing                                                                     import ForwardRef
+from typing                                                                     import ForwardRef, Union
 from osbot_utils.type_safe.Type_Safe__Primitive                                 import Type_Safe__Primitive
 from osbot_utils.type_safe.type_safe_core.collections.Type_Safe__Dict           import Type_Safe__Dict
 from osbot_utils.type_safe.type_safe_core.collections.Type_Safe__List           import Type_Safe__List
@@ -103,13 +103,16 @@ def convert_value_to_type_safe_objects(self, __self, key, value):
             else:
 
                 origin = type_safe_annotations.get_origin(annotation)
+                if origin is Union:
+                    return value
+
                 # If the value is an empty container, create proper type-safe container
                 if ((isinstance(value, list ) and len(value) == 0) or
                     (isinstance(value, dict ) and len(value) == 0) or
                     (isinstance(value, set  ) and len(value) == 0) or
                     (isinstance(value, tuple) and len(value) == 0)):
                     value = type_safe_step_default_value.default_value(__self.__class__, annotation)        # Use default_value to create the proper type-safe container
-                            # Handle non-empty list
+
                 elif origin is list and isinstance(value, list):
                     args = get_args(annotation)
                     if args:                                                        # Only create Type_Safe__List if we have type info

tests/unit/type_safe/type_safe_core/_bugs/test_Type_Safe__bugs.py

@@ -6,6 +6,7 @@
 class test_Type_Safe__bugs(TestCase):
 
 
+
     def test__bug__property_descriptor_handling__doesnt_enforce_type_safety(self):
 
         class Test_Class(Type_Safe):

tests/unit/type_safe/type_safe_core/_regression/test_Type_Safe__regression.py

@@ -32,6 +32,12 @@
 class Node_Value(Type_Safe):
     value: int
 
+class Base__Type(Type_Safe):
+    ref_type: Type['Base__Type']
+
+class Type__With__Forward__Ref(Base__Type):
+    pass
+
 class test_Type_Safe__regression(TestCase):
 
     def test__regression__type_safe_step_init__issue_with_Dict_with_not_types(self):
@@ -1603,9 +1609,37 @@ class Cache_Entry_H(Type_Safe):
             an_guid     : Random_Guid                                           # as soon as we add the Random_Guid
 
         assert Cache_Entry_H().entry_id   != Cache_Entry_H().entry_id           # it works again
+    def test__regression__empty_dict__assigns_to_none(self):
+        class Schema__Cache__Data__Store__Request(Type_Safe):
+            data        : Union[str, dict, bytes]   = None
 
-class Base__Type(Type_Safe):
-    ref_type: Type['Base__Type']
+        request_1 = Schema__Cache__Data__Store__Request()
+        assert request_1.data is None
 
-class Type__With__Forward__Ref(Base__Type):
-    pass
+        request_2 = Schema__Cache__Data__Store__Request(data=None)
+        assert request_2.data is None
+
+        request_3 = Schema__Cache__Data__Store__Request(data={})
+        #assert request_3.data is None                                       # BUG
+        assert request_3.data == {}
+
+        request_3 = Schema__Cache__Data__Store__Request(data={'a':42})
+        assert request_3.data == {'a':42 }
+
+        class An_Class_1(Type_Safe):
+            data        : dict  = None
+
+        class An_Class_2(Type_Safe):
+            data        : Union[str, dict, bytes]   = None
+
+        class An_Class_3(Type_Safe):
+            data        : Union[str, Dict, bytes]   = None
+
+        assert An_Class_1(       ).data is None
+        assert An_Class_2(       ).data is None
+
+        assert An_Class_1(data={}).data == {}
+        #assert An_Class_2(data={}).data is None                             # BUG
+        #assert An_Class_3(data={}).data is None                             # BUG
+        assert An_Class_2(data={}).data == {}
+        assert An_Class_3(data={}).data == {}