Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Presign URLs are compatible with any storage class #770

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jriouovh
Copy link
Contributor

Description

  • Remove the note on cloud_project_region_storage_presign resource telling it's compatible only with the High Performance storage class. Pre-signed URLs are compatible with any class.
  • Region name must be in uppercase

Type of change

Please delete options that are not relevant.

  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

- Remove the note on cloud_project_region_storage_presign resource telling it's
  compatible only with the High Performance storage class. Pre-signed URLs are
compatible with any class.
- Region name must be in uppercase

Signed-off-by: Julien Riou <julien.riou@ovhcloud.com>
@amstuta amstuta merged commit 5bbcd92 into ovh:master Nov 13, 2024
* `method` - (Required) The method you want to use to interact with your object. Can be either 'GET' or 'PUT'.
* `object` - (Required) The name of the object in your S3 bucket.
- `region_name` - (Required) The region in which your storage is located. Must
be in **uppercase**. Ex.: "GRA".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the region must be in uppercase, should the terraform provider take care of putting it in uppercase if it was supplied in lower case ?

for example here:

regionName := d.Get("region_name").(string)

This would prevent confusion when some documentation state that regions must be in lower case: https://help.ovhcloud.com/csm?id=kb_article_view&sysparm_article=KB0047384
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea: #772 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants