Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Missing "description" argument in ovh_dedicated_nasha_partition_access #677

Closed
131 opened this issue Jul 7, 2024 · 4 comments · Fixed by #678
Closed

[FEATURE] Missing "description" argument in ovh_dedicated_nasha_partition_access #677

131 opened this issue Jul 7, 2024 · 4 comments · Fixed by #678

Comments

@131
Copy link

131 commented Jul 7, 2024

Description

Looking up multiple IP in ovh_dedicated_nasha_partition_access is tedious (when using the manager) hence the "description" that might be used as a hint on the server name.

Yet, this argument cannot be managed by the terraform provider.
If this is a quick adjustment, this is a big improvement for us

Affected Resource(s) and/or Data Source(s)

  • ovh_dedicated_nasha_partition_access

Potential Terraform Configuration

resource "ovh_dedicated_nasha_partition_access" "main" {
  for_each = var.allowed_ips

  service_name   = ovh_dedicated_nasha_partition.main.service_name
  partition_name = ovh_dedicated_nasha_partition.main.name
  ip             = each.value
  //description    = "tf-{each.key}-rw"

  type = "readwrite"
}
@amstuta
Copy link
Contributor

amstuta commented Jul 8, 2024

Hello @131 , indeed I see that the field aclDescription is available in the API but missing in the TF resource. We'll add it quickly.

@131
Copy link
Author

131 commented Jul 8, 2024

Wow.
Thanks

@131
Copy link
Author

131 commented Jul 8, 2024

hmm, updating, the acl_description result in a resource being destroy rather than updated.
Seems a bit aggressive , is it possible to change that ?

@amstuta
Copy link
Contributor

amstuta commented Jul 9, 2024

In fact, we don't have any other choice here since no route exists on the API to update an existing ACL, so have to recreate it when updating the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants