Skip to content

Commit d17ad8e

Browse files
committed
fixed base classes passing to trigger
1 parent 47a45e2 commit d17ad8e

File tree

3 files changed

+60
-6
lines changed

3 files changed

+60
-6
lines changed

__tests__/trigger-unit-test.js

Lines changed: 45 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,55 @@ import renderElement from './helpers/renderElement';
66

77

88
test('trigger Component', nested => {
9-
nested.test('Renders trigger component:',
9+
nested.test('Trigger type: button',
1010
assert => {
11-
11+
const trigger = renderElement(<Trigger kitid="but" type='button'>Button trigger</Trigger>).dom();
12+
13+
const actualText = trigger.html();
14+
const expectedText = '<button type="button" class="uk-button uk-width-1-1" data-kitid="but">Button trigger </button>';
15+
assert.equals(actualText, expectedText,
16+
'Correctly renders trigger element as button');
17+
18+
assert.end();
19+
});
20+
21+
22+
nested.test('Trigger type: link',
23+
assert => {
24+
const trigger = renderElement(<Trigger kitid="link" type='link'>Link trigger</Trigger>).dom();
25+
26+
const actualText = trigger.html();
27+
const expectedText = '<a class="uk-button uk-width-1-1" data-kitid="link" href="#" role="button">Link trigger </a>';
28+
assert.equals(actualText, expectedText,
29+
'Correctly renders trigger element as link');
30+
31+
assert.end();
32+
});
33+
34+
35+
nested.test('Trigger type: span',
36+
assert => {
37+
const trigger = renderElement(<Trigger kitid="span" type='span'>Span trigger</Trigger>).dom();
38+
39+
const actualText = trigger.html();
40+
const expectedText = '<span data-kitid="span">Span trigger </span>';
41+
assert.equals(actualText, expectedText,
42+
'Correctly renders trigger element as span');
1243

1344
assert.end();
1445
});
1546

1647

48+
nested.test('Trigger type: div',
49+
assert => {
50+
const trigger = renderElement(<Trigger kitid="div" type='div'>Span trigger</Trigger>).dom();
51+
52+
const actualText = trigger.html();
53+
const expectedText = '<div data-kitid="div">Span trigger </div>';
54+
assert.equals(actualText, expectedText,
55+
'Correctly renders trigger element as div');
56+
57+
assert.end();
58+
});
59+
1760
});

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-uikit-trigger",
3-
"version": "0.1.2",
3+
"version": "0.1.3",
44
"description": "React uikit trigger component.",
55
"keywords": [
66
"javascript",
@@ -54,6 +54,7 @@
5454
"watch": "~0.16.0"
5555
},
5656
"dependencies": {
57+
"babel-cli": "~6.1.8",
5758
"react": "~0.14.3",
5859
"react-uikit-base": "~0.2.2",
5960
"react-uikit-button": "~0.2.0",

src/trigger.jsx

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,18 @@ const Trigger = (props) => {
1010
const icon = ufunc.maybeIf(<i className={`uk-icon-${props.icon}`}/>)(props.icon);
1111

1212
const cleanProps = uikit.helpers.cleanProps(['icon'])(props);
13+
const cleanPropType = uikit.helpers.cleanProps(['type'])(props);
14+
15+
const cssClassNames = uikit.helpers.cleanClasses([
16+
props.classes,
17+
props.className
18+
]);
1319

1420
const type = {
1521
button: <Button
1622
{...props}
1723
{...cleanProps}
24+
className={cssClassNames}
1825
block
1926
kitid={props.kitid}
2027
body={props.body}
@@ -25,6 +32,8 @@ const Trigger = (props) => {
2532
link: <Button
2633
{...props}
2734
{...cleanProps}
35+
{...cleanPropType}
36+
className={cssClassNames}
2837
block
2938
kitid={props.kitid}
3039
type='link'
@@ -36,8 +45,9 @@ const Trigger = (props) => {
3645
span : <span
3746
{...props}
3847
{...cleanProps}
48+
{...cleanPropType}
3949
{...uikit.helpers.events}
40-
col='1-1'
50+
className={cssClassNames}
4151
data-kitid={props.kitid}
4252
>
4353
{props.body}
@@ -47,7 +57,8 @@ const Trigger = (props) => {
4757
div: <div
4858
{...props}
4959
{...cleanProps}
50-
col='1-1'
60+
{...cleanPropType}
61+
className={cssClassNames}
5162
{...uikit.helpers.events}
5263
data-kitid={props.kitid}
5364
>
@@ -56,7 +67,6 @@ const Trigger = (props) => {
5667
</div>
5768
};
5869

59-
6070
return ufunc.either(type[props.type], type['button'])(props.type);
6171
};
6272

0 commit comments

Comments
 (0)