Merge pull request #113 from matthewloring/promise

Makes WrappedPromise an ES6 class

Author: watson

es6-wrapped-promise.js

@@ -0,0 +1,37 @@
+'use strict';
+
+module.exports = (Promise, ensureAslWrapper) => {
+  // Updates to this class should also be applied to the the ES3 version
+  // in index.js.
+  return class WrappedPromise extends Promise {
+    constructor(executor) {
+      var context, args;
+      super(wrappedExecutor);
+      var promise = this;
+
+      try {
+        executor.apply(context, args);
+      } catch (err) {
+        args[1](err);
+      }
+
+      return promise;
+      function wrappedExecutor(resolve, reject) {
+        context = this;
+        args = [wrappedResolve, wrappedReject];
+
+        // These wrappers create a function that can be passed a function and an argument to
+        // call as a continuation from the resolve or reject.
+        function wrappedResolve(val) {
+          ensureAslWrapper(promise, false);
+          return resolve(val);
+        }
+
+        function wrappedReject(val) {
+          ensureAslWrapper(promise, false);
+          return reject(val);
+        }
+      }
+    }
+  }
+};

index.js

@@ -10,6 +10,7 @@ var shimmer      = require('shimmer')
   , util         = require('util')
   ;
 
+var v6plus = semver.gte(process.version, '6.0.0');
 var v7plus = semver.gte(process.version, '7.0.0');
 
 var net = require('net');
@@ -391,6 +392,8 @@ if (instrumentPromise) {
 function wrapPromise() {
   var Promise = global.Promise;
 
+  // Updates to this class should also be applied to the the ES6 version
+  // in es6-wrapped-promise.js.
   function wrappedPromise(executor) {
     if (!(this instanceof wrappedPromise)) {
       return Promise(executor);
@@ -407,7 +410,7 @@ function wrapPromise() {
     try {
       executor.apply(context, args);
     } catch (err) {
-      args[1](err)
+      args[1](err);
     }
 
     return promise;
@@ -438,23 +441,26 @@ function wrapPromise() {
     wrap(Promise.prototype, 'chain', wrapThen);
   }
 
-  var PromiseFunctions = [
-    'all',
-    'race',
-    'reject',
-    'resolve',
-    'accept',  // Node.js <v7 only
-    'defer'    // Node.js <v7 only
-  ];
-
-  PromiseFunctions.forEach(function(key) {
-    // don't break `in` by creating a key for undefined entries
-    if (typeof Promise[key] === 'function') {
-      wrappedPromise[key] = Promise[key];
-    }
-  });
-
-  global.Promise = wrappedPromise;
+  if (v6plus) {
+    global.Promise = require('./es6-wrapped-promise.js')(Promise, ensureAslWrapper);
+  } else {
+    var PromiseFunctions = [
+      'all',
+      'race',
+      'reject',
+      'resolve',
+      'accept',  // Node.js <v7 only
+      'defer'    // Node.js <v7 only
+    ];
+
+    PromiseFunctions.forEach(function(key) {
+      // don't break `in` by creating a key for undefined entries
+      if (typeof Promise[key] === 'function') {
+        wrappedPromise[key] = Promise[key];
+      }
+    });
+    global.Promise = wrappedPromise
+  }
 
   function ensureAslWrapper(promise, overwrite) {
     if (!promise.__asl_wrapper || overwrite) {

test/native-promises.tap.js

@@ -2198,3 +2198,21 @@ if (typeof Promise.prototype.chain === 'function') {
     }
   });
 }
+
+test('subclasses', function(t) {
+  if (nodeVersion[0] < 6) {
+    // class syntax is not supported before node 6.
+    t.end();
+    return;
+  }
+
+  // SubclassedPromise does 2 asserts.
+  t.plan(3);
+
+  var SubclassedPromise = require('./promise-subclass.js')(t);
+
+  var s = SubclassedPromise.resolve(42).then(function(val) {
+    t.strictEqual(val, 42);
+    t.end();
+  });
+});

test/promise-subclass.js

@@ -0,0 +1,11 @@
+'use strict';
+
+module.exports = (tap) => {
+  return class SubclassedPromise extends Promise {
+    then(onSuccess, onReject) {
+      tap.type(onSuccess, 'function');
+      tap.type(onReject, 'undefined');
+      return Promise.prototype.then.call(this, onSuccess, onReject);
+    }
+  };
+};