Adding code review comments.

Author: fernamig

src/tests/unit/documents-serializer.test.js

@@ -23,14 +23,14 @@ describe('Test documents-serializer', () => {
     const document = {
       id: 'fake id',
     };
-    const result = serializeDocument(document, {method: 'POST', query: 'fake'});
+    const result = serializeDocument(document, { method: 'POST', query: 'fake' });
     return testSingleResource(result);
   });
   it('serializeDocument should properly serialize a single document (GET) in JSON API format', () => {
     const document = {
       id: 'fake id',
     };
-    const result = serializeDocument(document, {method: 'GET', query: 'fake'});
+    const result = serializeDocument(document, { method: 'GET', query: 'fake' });
     return testSingleResource(result);
   });
 });

src/tests/unit/keywords-serializer.test.js

@@ -16,14 +16,14 @@ describe('Test keywords-serializer', () => {
     const updatedKeywordCollection = {
       id: 'fake id',
     };
-    const result = serializeKeywords(updatedKeywordCollection, {method: 'POST', query: 'fake'});
+    const result = serializeKeywords(updatedKeywordCollection, { method: 'POST', query: 'fake' });
     return testSingleResource(result);
   });
   it('serializeKeywords should properly serialize keywords collection (GET) in JSON API format', () => {
     const updatedKeywordCollection = {
       id: 'fake id',
     };
-    const result = serializeKeywords(updatedKeywordCollection, {method: 'GET', query: 'fake'});
+    const result = serializeKeywords(updatedKeywordCollection, { method: 'GET', query: 'fake' });
     return testSingleResource(result);
   });
 });

src/tests/unit/onbase-dao.test.js

@@ -12,7 +12,7 @@ import {
   createError,
   testResultData,
   testResultError,
-  testResultThrowsMessage
+  testResultThrowsMessage,
 } from './test-helpers';
 
 chai.should();
@@ -65,8 +65,8 @@ const runErrorSuite = (testLabel, getter, errReturn, errThrowObj, errThrowMsg) =
   if (errReturn) {
     it(`${testLabel} request returns error ${errReturn.response.status}`,
       () => {
-        let stubAxios = sinon.stub().rejects(errReturn);
-        let onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+        const stubAxios = sinon.stub().rejects(errReturn);
+        const onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
         testResultError(
           getter(onbaseDao),
           errReturn.response.data.detail,
@@ -76,8 +76,8 @@ const runErrorSuite = (testLabel, getter, errReturn, errThrowObj, errThrowMsg) =
   }
   it(`${testLabel} request throws ${errThrowObj.response.status}`,
     () => {
-      let stubAxios = sinon.stub().rejects(errThrowObj);
-      let onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+      const stubAxios = sinon.stub().rejects(errThrowObj);
+      const onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
       testResultThrowsMessage(
         getter(onbaseDao),
         '[object Object]',
@@ -86,8 +86,8 @@ const runErrorSuite = (testLabel, getter, errReturn, errThrowObj, errThrowMsg) =
     });
   it(`${testLabel} request throws ${errThrowMsg.response.status}`,
     () => {
-      let stubAxios = sinon.stub().rejects(errThrowMsg);
-      let onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+      const stubAxios = sinon.stub().rejects(errThrowMsg);
+      const onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
       testResultThrowsMessage(
         getter(onbaseDao),
         errThrowMsg.response.data.detail,
@@ -101,15 +101,15 @@ const error204 = createError(204);
 const error400 = createError(400);
 const error404 = createError(404);
 const error413 = createError(413);
-  
+
 describe('Test onbase-dao (non-keyword types)', () => {
   let stubAxios;
   let onbaseDao;
 
   beforeEach(() => {
     createConfigStub();
     stubAxios = sinon.stub().callsFake(() => fakeData);
-    onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+    onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
     sinon.stub(setCookie, 'parse').returns([{
       name: 'FB_LB',
       value: 'fake cookie',
@@ -140,7 +140,7 @@ describe('Test onbase-dao (non-keyword types)', () => {
   runErrorSuite('initiateStagingArea',
     (dao) => dao.initiateStagingArea('fake token', 'fake fbLb', 'PDF', 1024),
     undefined, error201, error413);
-    
+
   it('uploadFile should return a valid result',
     () => testResultCookieOnly(
       onbaseDao.uploadFile('fake token', 'fake fbLb', 'fake', 'fake', 'fake', 'fake'),
@@ -152,7 +152,7 @@ describe('Test onbase-dao (non-keyword types)', () => {
   it('uploadFile request returns error 413',
     () => {
       stubAxios = sinon.stub().rejects(error413);
-      onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+      onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
       testResultError(
         onbaseDao.uploadFile('fake token', 'fake fbLb', 'fake', 'fake', 'fake', 'fake'),
         '[object Object]',
@@ -287,10 +287,10 @@ describe('Test onbase-dao (non-keyword types)', () => {
     undefined, error200, error201);
   it('createQuery request returns error 999',
     () => {
-      let error = createError(999);
+      const error = createError(999);
       error.response.data.detail = 'Some of the provided input data is invalid';
       stubAxios = sinon.stub().rejects(error);
-      onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+      onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
       testResultError(
         onbaseDao.createQuery('fake token', 'fake fbLb', 'fake 1', 'fake 1', 'fake 1', 'fake 1'),
         '[object Object]',
@@ -326,7 +326,7 @@ describe('Test onbase-dao (keyword types)', () => {
   beforeEach(() => {
     createConfigStub();
     stubAxios = sinon.stub().callsFake(() => fakeKeywordsTypesData);
-    onbaseDao = proxyquire('db/http/onbase-dao', {axios: stubAxios});
+    onbaseDao = proxyquire('db/http/onbase-dao', { axios: stubAxios });
     sinon.stub(setCookie, 'parse').returns([{
       name: 'FB_LB',
       value: 'fake cookie',
@@ -347,7 +347,7 @@ describe('Test onbase-dao (keyword types)', () => {
   runErrorSuite('getDocumentKeywordTypes',
     (dao) => dao.getDocumentKeywordTypes('fake token', 'fake fbLb', [keyword1, keyword2]),
     error404, error200, error201);
-    
+
   it('getKeywordTypesByNames should return a valid result',
     () => testResultWithCookie(
       onbaseDao.getKeywordTypesByNames('fake token', 'fake fbLb',

src/tests/unit/test-helpers.js

@@ -127,21 +127,19 @@ const testMultipleResources = (serializedResources) => {
 /**
  * Helper function for creating an error response for a web request.
  *
- * @param {int} code the HTTP status code of the error
+ * @param {number} code the HTTP status code of the error
  * @returns {object} an error resonse object
  */
-const createError = (code) => {
-  return {
-    'response': {
-      'status': code,
-       'data': {
-         'error': `${code} error`,
-         'error_description': `${code} error message`,
-         'detail': `${code} error message`,
-        }
-      }
-    };
-};
+const createError = (code) => ({
+  response: {
+    status: code,
+    data: {
+      error: `${code} error`,
+      error_description: `${code} error message`,
+      detail: `${code} error message`,
+    },
+  },
+});
 
 /**
  * Helper function for testing that the result contains data