Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare-root: boot is kept writable #3365

Open
cgwalters opened this issue Jan 6, 2025 · 0 comments
Open

prepare-root: boot is kept writable #3365

cgwalters opened this issue Jan 6, 2025 · 0 comments

Comments

@cgwalters
Copy link
Member

If we don't have a separate /boot today, then the prepare root code makes a bind mount to the physical path.

In the case of sysroot.readonly=true, this is done before we set up the readonly state, leaving /boot writable which I think is not expected.

Separately but definitely related to this we have this code in the sysroot logic:

  if (!remount_writable ("/boot", &did_remount_boot, error))
    return FALSE;

This checks for ST_RDONLY and tries to remount if it finds that, but that's broken - we need to check if it's actually a mountpoint instead.

These bugs seem to currently cancel out, but I saw at least one person reporting

$ bootc status
ERROR Status: Initializing storage: Acquiring sysroot: Remounting /boot read-write: Invalid argument

which is almost certainly hitting the latter case somehow.

Fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant