Add a builtin command to pin the current deployment?

[juhp]

Would it make sense to add a built-in command (or option) to pin the current deployment?
(I actually wrote a tiny tool to do this already but in Haskell: https://github.com/juhp/ostree-pin/blob/master/Main.hs.)
I think this would be useful on Silverblue, where it is easy to "lose" one's last "good" deployment (ie with just a reboot into stage and then one more rpm-ostree operation and a reboot).

I am thinking something like ostree admin pin --current.

[juhp]

I should add that I really want a bit more than just pinning the booted deployment - actually I want to move the pin to the current deployment.

[jlebon]

Would it make sense to add a built-in command (or option) to pin the current deployment?

This could probably be an rpm-ostree command, e.g. rpm-ostree pin.

I think this would be useful on Silverblue, where it is easy to "lose" one's last "good" deployment (ie with just a reboot into stage and then one more rpm-ostree operation).

Yeah, that's bothered me as well in the past. I think what we may want to express here is GC based on versions rather than number of deployments. So no matter the number of e.g. rpm-ostree install follow-up operations, you always keep at least one deployment of the previous version. This would probably be an rpm-ostree thing though, since that's where the base/layer concepts live.

[juhp]

That's an attractive idea and probably better than just keeping 3 deployments.
I suppose this could also be implemented by pinning perhaps.

[jlebon]

OK, split that one out as coreos/rpm-ostree#1905. We can keep this here to track the original request too though (though I do think we should wrap pin in rpm-ostree, so would be good with just moving this issue there too -- but let's see if anyone else is interested in enhancing ostree admin pin specifically).