Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 #3699

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 #3699

merged 7 commits into from
Jul 26, 2023

Conversation

feixintianxia
Copy link
Contributor

@feixintianxia feixintianxia commented Jul 21, 2023 •
edited by winlinvip
Loading

It is advised to eliminate any instances of _srs_rtc_manager that occur multiple times.

Co-authored-by: john hondaxiao@tencent.com
Co-authored-by: chundonglinlin chundonglinlin@163.com

@xiaozhihong
Copy link
Collaborator

@feixintianxia There are additional duplicate extern variables in the same file. Should you remove them as well?

@xiaozhihong
Copy link
Collaborator

xiaozhihong commented Jul 25, 2023 •
edited by winlinvip
Loading

Thank you very much, brother.

TRANS_BY_GPT3

@winlinvip winlinvip changed the title Bugfix: repeate define _srs_rtc_manager Fix: Duplicate definition of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip changed the title Fix: Duplicate definition of _srs_rtc_manager Repair: Eliminate Duplicate Definition of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip added the Enhancement Improvement or enhancement. label Jul 26, 2023
@winlinvip winlinvip changed the title Repair: Eliminate Duplicate Definition of _srs_rtc_manager Repair: Remove Duplicate _srs_rtc_manager Definition Jul 26, 2023
@winlinvip winlinvip added the RefinedByAI Refined by AI/GPT. label Jul 26, 2023
@winlinvip winlinvip changed the title Repair: Remove Duplicate _srs_rtc_manager Definition Fix: Eliminate Duplicate _srs_rtc_manager Declaration Jul 26, 2023
@winlinvip winlinvip changed the title Fix: Eliminate Duplicate _srs_rtc_manager Declaration Repair: Remove Duplicate _srs_rtc_manager Declaration Jul 26, 2023
@winlinvip winlinvip changed the title Repair: Remove Duplicate _srs_rtc_manager Declaration Repair: Eliminate duplicate declaration of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip changed the title Repair: Eliminate duplicate declaration of _srs_rtc_manager Fix: Remove duplicate declaration of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip changed the title Fix: Remove duplicate declaration of _srs_rtc_manager Pull Request: Deleting redundant declaration of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip changed the title Pull Request: Deleting redundant declaration of _srs_rtc_manager Remove duplicate declaration of _srs_rtc_manager in Pull Request Jul 26, 2023
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch 2 times, most recently from 696833b to 0cf0456 Compare July 26, 2023 00:59
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch from 696833b to 0cf0456 Compare July 26, 2023 01:10
@winlinvip winlinvip changed the title Remove duplicate declaration of _srs_rtc_manager in Pull Request Remove redundant _srs_rtc_manager declaration in Pull Request Jul 26, 2023
@winlinvip winlinvip changed the title Remove redundant _srs_rtc_manager declaration in Pull Request Pull Request: Eliminate duplicate _srs_rtc_manager declaration Jul 26, 2023
@winlinvip winlinvip changed the title Pull Request: Eliminate duplicate _srs_rtc_manager declaration Remove duplicate declaration of _srs_rtc_manager in Pull Request Jul 26, 2023
@winlinvip winlinvip changed the title Remove duplicate declaration of _srs_rtc_manager in Pull Request Pull Request title: 'Eliminate duplicate declaration of _srs_rtc_manager in Pull Request Jul 26, 2023
@winlinvip winlinvip changed the title Pull Request title: 'Eliminate duplicate declaration of _srs_rtc_manager in Pull Request Bugfix: Eliminate duplicate declaration of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch from 559ad91 to 0cf0456 Compare July 26, 2023 01:15
@winlinvip winlinvip changed the title Bugfix: Eliminate duplicate declaration of _srs_rtc_manager Bugfix: Remove the redundant declaration of _srs_rtc_manager Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Remove the redundant declaration of _srs_rtc_manager. Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. Jul 26, 2023
@winlinvip
Copy link
Member

winlinvip commented Jul 26, 2023 •
edited
Loading

Test

TRANS_BY_GPT3

@winlinvip winlinvip changed the title Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager. Jul 26, 2023
@winlinvip winlinvip self-requested a review July 26, 2023 02:46
winlinvip
winlinvip reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@winlinvip winlinvip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test multiple reviews

TRANS_BY_GPT3

trunk/src/app/srs_app_threads.cpp
extern SrsDtlsCertificate* _srs_rtc_dtls_certificate;
#endif

#include <srs_protocol_kbps.hpp>

extern SrsPps* _srs_pps_snack2;
Copy link
Member

@winlinvip winlinvip Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

TRANS_BY_GPT3

Copy link
Member

@winlinvip winlinvip Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test translation

TRANS_BY_GPT3

Copy link
Member

@winlinvip winlinvip Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation test

TRANS_BY_GPT3

winlinvip
winlinvip reviewed Jul 26, 2023
View reviewed changes
trunk/src/app/srs_app_threads.cpp
extern SrsDtlsCertificate* _srs_rtc_dtls_certificate;
#endif

#include <srs_protocol_kbps.hpp>

extern SrsPps* _srs_pps_snack2;
extern SrsPps* _srs_pps_snack3;
extern SrsPps* _srs_pps_snack4;
Copy link
Member

@winlinvip winlinvip Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test individual Review

TRANS_BY_GPT3

@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager. Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager. Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager. Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. v5.0.169 v6.0.62 Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. v5.0.169 v6.0.62 Bugfix: Remove the redundant declaration of the _srs_rtc_manager. v5.0.170 v6.0.63 Jul 26, 2023
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch from ad564a9 to 0cf0456 Compare July 26, 2023 03:20
@winlinvip winlinvip changed the title Bugfix: Remove the redundant declaration of the _srs_rtc_manager. v5.0.170 v6.0.63 Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager in versions 5.0.170 and 6.0.63. Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager in versions 5.0.170 and 6.0.63. Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. v5.0.170 and 6.0.63. Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Eliminate the superfluous declaration of the _srs_rtc_manager. v5.0.170 and 6.0.63. Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager.. v5.0.170 and 6.0.63. Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager.. v5.0.170 and 6.0.63. Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager. v5.0.170 and 6.0.63. Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager. v5.0.170 and 6.0.63. Bugfix: Remove the duplicate declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Jul 26, 2023
@winlinvip winlinvip changed the title Bugfix: Remove the duplicate declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Jul 26, 2023
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch from f1c14f6 to 0cf0456 Compare July 26, 2023 04:29
@winlinvip winlinvip linked an issue Jul 26, 2023 that may be closed by this pull request
SRS_SANITIZER cannot be closed #3715
Closed
@winlinvip winlinvip removed a link to an issue Jul 26, 2023
SRS_SANITIZER cannot be closed #3715
Closed
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch from f1c14f6 to 0cf0456 Compare July 26, 2023 10:15
@winlinvip winlinvip changed the title Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Jul 26, 2023
@winlinvip winlinvip force-pushed the bugfix/repeate_define_variables branch from 97c4804 to 0cf0456 Compare July 26, 2023 11:34
@winlinvip winlinvip changed the title Bugfix: Remove the unnecessary declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager variable. v5.0.169 v6.0.62 Jul 26, 2023
@winlinvip winlinvip merged commit 2777351 into ossrs:develop Jul 26, 2023
17 checks passed
winlinvip pushed a commit that referenced this pull request Jul 26, 2023
@feixintianxia @xiaozhihong
@chundonglinlin @winlinvip
Bugfix: Eliminate the redundant declaration of the _srs_rtc_manager v…
08147f8 
…ariable. v5.0.169 (#3699)

It is advised to eliminate any instances of _srs_rtc_manager that occur
multiple times.

---------

Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: chundonglinlin <chundonglinlin@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winlinvip winlinvip winlinvip left review comments

@chundonglinlin chundonglinlin chundonglinlin approved these changes

@duiniuluantanqin duiniuluantanqin Awaiting requested review from duiniuluantanqin

Assignees
No one assigned
Labels
Enhancement Improvement or enhancement. RefinedByAI Refined by AI/GPT. TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feixintianxia @xiaozhihong @winlinvip @chundonglinlin