srs rejects request while downstream server disconnects and then reconnects in a short time. #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix: misleading error log information for transcode engine config param.
…hen reconnects in a short time. bugfix: while downstream server disconnects and reconnects in a short time, srs rejects the push request because SrsForwarder::cycle is sleeping for SRS_FORWARDER_CIMS, and the stream is still busy.
|
Hmm, this critical situation indeed deserves careful handling.
|
winlinvip
force-pushed
the
3.0release
branch
27 times, most recently
from
af2f6bb
to
3c0fc9b
Compare
winlinvip
force-pushed
the
3.0release
branch
4 times, most recently
from
1ca9308
to
8d44b98
Compare
winlinvip
added a commit
that referenced
this pull request
Oct 30, 2021
winlinvip
reviewed
Oct 30, 2021
| // | ||
| // We always check status first. | ||
| // @see https://github.com/ossrs/srs/issues/1634#issuecomment-597571561 | ||
| if ((err = trd->pull()) != srs_success) { |
There was a problem hiding this comment.
Thank you very much 👍
It would be more appropriate to add error detection before and after the Forward cycle.
I have already merged this place: link
TRANS_BY_GPT3
Edge should also be needed. Otherwise, it will keep retrying. @winlinvip
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: while downstream server disconnects and reconnects in a short time, srs rejects the push request because SrsForwarder::cycle is sleeping for SRS_FORWARDER_CIMS, and the stream is still busy.