Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC: Failed to handshake with OBS WHIP #3521

Closed
SetoKaiba opened this issue Apr 22, 2023 · 3 comments · Fixed by #3581
Closed

WebRTC: Failed to handshake with OBS WHIP #3521

SetoKaiba opened this issue Apr 22, 2023 · 3 comments · Fixed by #3581
Assignees
Labels
TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.

Comments

@SetoKaiba
Copy link

SetoKaiba commented Apr 22, 2023

Note: Please read FAQ before file an issue, see #2716

Description

WebRTC is not compatible with the WHIP branch of OBS.
The testing server provided by the OBS project team, https://b.siobud.com/, can stream and receive normally.
ZLM can also stream and receive normally.

  1. SRS Version: 6.0.41, the latest version compiled from the develop branch.
  2. SRS Log:
    Question 1) In the related log, it can be seen that the part after the colon in the username is missing. This is because the OBS parsing does not support ice-ufrag in the global section. This can be temporarily resolved through the Johzzy branch.
    https://github.com/johzzy/srs/tree/feature/obs
[2023-03-31 09:56:02.364][INFO][23][go5397c1] RTC username=5759z3ye:, offer=1170B, answer=1348B

Question 2) In the related log, it appears to be an encoding issue, but after confirming with the OBS project team, it is confirmed that there is SPSPPS information available.

[2023-04-02 23:31:02.151][WARN][11085][002lp93r][11] avc ignore type=1 for no sequence header

UPDATE: When pulling the latest Johzzy's OBS branch, an error occurred at the SDP step, making it impossible to confirm problem 2.

  1. SRS Config:
rtc2rtmp.conf

Replay

Please describe how to replay the bug?

Step 1: Run SRS.

Step 2: Use OBS for WHIP streaming.

Expect

It should run normally.

Other Known Issues

TRANS_BY_GPT3

@winlinvip winlinvip changed the title WebRTC无法兼容OBS的WHIP分支。 WebRTC: Failed to handshake with OBS WHIP May 1, 2023
@winlinvip
Copy link
Member

winlinvip commented May 1, 2023

OBS WHIP has not been formally submitted as a PR yet, there may still be changes, so you can wait and take another look.

TRANS_BY_GPT3

@winlinvip winlinvip added the WebRTC WebRTC, RTC2RTMP or RTMP2RTC. label May 1, 2023
@SetoKaiba
Copy link
Author

SetoKaiba commented Jun 10, 2023

obsproject/obs-studio#7926
Now the PR for WHIP support in OBS has been merged.
Can srs be compatible?

TRANS_BY_GPT3

@winlinvip
Copy link
Member

Yes, now that the pull request for OBS WHIP has been merged, SRS should be able to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants