Skip to content

WHIP: X509 cert serial number should be positive. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: workflows
Choose a base branch
from

Conversation

winlinvip
Copy link
Member

@winlinvip winlinvip commented Jun 10, 2025

According to RFC5280 4.1.2.2, The serial number MUST be a positive integer assigned by the CA to each certificate.

@winlinvip
Copy link
Member Author

Since Go1.23, Go DTLS server may fail the FFmpeg request, for it verify the serial number:

	if serial.Sign() == -1 {
		if x509negativeserial.Value() != "1" {
			return nil, errors.New("x509: negative serial number")

See golang/go@db13584

@winlinvip winlinvip force-pushed the bugfix/cert-serial-number branch 18 times, most recently from 3f81f6b to 1269248 Compare June 10, 2025 21:31
@winlinvip winlinvip force-pushed the workflows branch 4 times, most recently from 3294e09 to 4aa17ba Compare June 10, 2025 22:58
@winlinvip winlinvip force-pushed the bugfix/cert-serial-number branch from 1269248 to 4192d9a Compare June 10, 2025 23:01
@winlinvip winlinvip force-pushed the bugfix/cert-serial-number branch from 4192d9a to ab60ac1 Compare June 10, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant