🌱 migrate to golangci-lint v2 #4641
Open
+325
−365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
this just treats the problem, but good enough for now Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4641 +/- ##
==========================================
+ Coverage 66.80% 68.29% +1.49%
==========================================
Files 230 249 +19
Lines 16602 18873 +2271
==========================================
+ Hits 11091 12890 +1799
- Misses 4808 5125 +317
- Partials 703 858 +155 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
jeffmendoza
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
linter update
What is the current behavior?
We use v1 of golangci-lint and dont get any updates.
Fix the current linter violations which can be confusing to contributors (e.g. #4639 (comment))
What is the new behavior (if this is a feature change)?**
We migrate to using v2
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Please review one commit at a time, as I tried to break them up, hopefully makes it easier.
The first commit was made by running
golangci-lint migrateand adding the comments back.Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)