Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support extracting zip archives #971

Open
maxfisher-g opened this issue Nov 16, 2023 · 2 comments
Open

support extracting zip archives #971

maxfisher-g opened this issue Nov 16, 2023 · 2 comments

Comments

@maxfisher-g
Copy link
Contributor

Some packages such as proactive-jupyter-kernel upload their source as a zip file which currently fails as the static analysis archive extraction expects a .tar.gz file.

We should do filetype detection using file (NOT the file extension) so that we can do static analysis on zip archives too

@gliptak
Copy link
Contributor

gliptak commented Mar 13, 2024

code to be updated seem to be at

func ExtractTarGzFile(tgzPath string, outputDir string) error {

might you be open to introducing something like https://github.com/mholt/archiver?

@maxfisher-g
Copy link
Contributor Author

Hi @gliptak, yes that's a good suggestion! I'd be open to introducing something like that. Please feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants