Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it impossible to mess up the schema.json #357

Closed
calebbrown opened this issue Sep 12, 2022 · 2 comments
Closed

Make it impossible to mess up the schema.json #357

calebbrown opened this issue Sep 12, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@calebbrown
Copy link
Contributor

The schema.json repeats the "import" and "install" sections, which means you have to remember to update both sections. And can cause issues like: #356. If only one section is updated the other will stop being imported.

Here are a couple of ideas:

  1. make "phase" a field in the schema, and remove the duplication (my preference, but old data can no longer be imported)
  2. add a check that is executed by a GitHub action that validates the JSON.
@calebbrown calebbrown added the bug Something isn't working label Sep 12, 2022
@maxfisher-g
Copy link
Contributor

At the very least, having a README for the schema.json where you can see the schema at a glance and make notes about this kind of stuff would make it "less possible" to mess it up.

@maxfisher-g
Copy link
Contributor

Subsumed under #960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants