Merge pull request scikit-build#85 from scikit-build/update-travis-python3-version

Fix SSL import when using pip or twine on Travis

Author: jcfr

.travis.yml

@@ -11,7 +11,7 @@ matrix:
     - os: osx
       language: generic
       env:
-        - PYTHON_VERSION=3.7.2
+        - PYTHON_VERSION=3.7.4
 
     - os: osx
       language: generic
@@ -20,12 +20,13 @@ matrix:
 
 cache:
   directories:
-    - $HOME/.pyenv/versions/3.7.2
+    - $HOME/.pyenv/versions/3.7.4
     - $HOME/.pyenv/versions/2.7.15
     - $HOME/downloads
 
 before_install:
   - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then mkdir $HOME/bin; ln -s $(which pip2) $HOME/bin/pip; ln -s $(which python2) $HOME/bin/python; fi
+  - python scripts/ssl-check.py
   - python -m pip install --disable-pip-version-check --upgrade pip
   - pip install -U scikit-ci scikit-ci-addons
   - ci_addons --install ../addons

scikit-ci.yml

@@ -20,6 +20,7 @@ before_install:
         SETUP_BDIST_WHEEL_ARGS: --plat-name macosx-10.6-x86_64
       commands:
         - python ../addons/travis/install_pyenv.py
+        - python scripts/ssl-check.py
         - python ../addons/travis/install_cmake.py 3.12.0
 
 install:

scripts/ssl-check.py

@@ -0,0 +1,32 @@
+# cf. https://github.com/pypa/manylinux/issues/53
+
+import sys
+
+GOOD_SSL = "https://google.com"
+BAD_SSL = "https://self-signed.badssl.com"
+
+print("Testing SSL certificate checking for Python:", sys.version)
+
+if (sys.version_info[:2] < (3, 4)):
+    print("This version never checks SSL certs; skipping tests")
+    sys.exit(0)
+
+if sys.version_info[0] >= 3:
+    from urllib.request import urlopen
+    EXC = OSError
+else:
+    from urllib import urlopen
+    EXC = IOError
+
+print("Connecting to %s should work" % (GOOD_SSL,))
+urlopen(GOOD_SSL)
+print("...it did, yay.")
+
+print("Connecting to %s should fail" % (BAD_SSL,))
+try:
+    urlopen(BAD_SSL)
+    # If we get here then we failed:
+    print("...it DIDN'T!!!!!11!!1one!")
+    sys.exit(1)
+except EXC:
+    print("...it did, yay.")