Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Verzik Vitur data. #194

Open
tyler-shaw opened this issue Nov 21, 2020 · 4 comments
Open

Issue with Verzik Vitur data. #194

tyler-shaw opened this issue Nov 21, 2020 · 4 comments
Assignees
Labels
bug monsters Anything to do with the monsters data, API or builder

Comments

@tyler-shaw
Copy link

When using the API, I noticed that the various forms of Verzik Vitur appear to have incorrect data.

All 3 forms have the same stats with the exception of their combat level.

Relevant links:

https://api.osrsbox.com/monsters/8370
https://api.osrsbox.com/monsters/8372
https://api.osrsbox.com/monsters/8374

Thanks

@osrsbox osrsbox self-assigned this Feb 3, 2021
@osrsbox
Copy link
Owner

osrsbox commented Feb 3, 2021

Hey @tyler-shaw - I had another look at this issue today. Looked at the wiki data, then my data. The problem is that the wiki uses a Switch infobox for the toggle of this NPC/monster. It is one of the very few (haven't counted, but judging off experience) wiki pages that does this. It seems this is used because there is an NPC version (from the quest) and a monster version (from TOB) that are on the same page - and my "parser" cannot handle these.
At the moment, it seems like a lot of work to add in Switch infobox parsing for a few outliers. But I will leave this issue open, and keep thinking of how to fix this.

@tyler-shaw
Copy link
Author

Thanks for the response.

Didn't want to make a new issue but adding another problematic monster here just for the record.

Monster ID 10589 (Urium Shade) shows in the NPC search tool but the data is missing from the API. https://api.osrsbox.com/monsters/10589

@osrsbox
Copy link
Owner

osrsbox commented Feb 17, 2021

Hey @tyler-shaw - thanks for reporting this. I am at a complete loss as to whats happening at the moment! Documenting some of this following for myself to try resolve:

Maybe today's update will solve this after a database rebuilt. Will keep an eye on it, and see what is happening.

EDIT...

@osrsbox
Copy link
Owner

osrsbox commented Feb 17, 2021

Just an update. Solved! The regex used for the API for monster ID was set to maximum of a 4 digit string. So any monster with an ID over 10,000 was not being parsed. When I first wrote that part, the ID only went up to 7000 or so. But it slowly increased over time. Thanks for reporting this @tyler-shaw - glad to get this bug fixed.

@osrsbox osrsbox added monsters Anything to do with the monsters data, API or builder and removed wontfix labels Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug monsters Anything to do with the monsters data, API or builder
Projects
None yet
Development

No branches or pull requests

2 participants