Skip to content

Conversation

@ruffsl
Copy link
Member

@ruffsl ruffsl commented Aug 8, 2019

Context: #295

ruffsl added 3 commits August 8, 2019 14:04
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
@ruffsl ruffsl marked this pull request as ready for review August 9, 2019 00:04
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! a few comments inline

| Type | Status |
|---|---|
| [amd64](https://hub.docker.com/r/amd64/gazebo/tags) | [![Build Status](https://doi-janky.infosiftr.net/buildStatus/icon?job=multiarch/amd64/gazebo)](https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/gazebo/) |
| [arm32v7](https://hub.docker.com/r/arm32v7/gazebo/tags) | [![Build Status](https://doi-janky.infosiftr.net/buildStatus/icon?job=multiarch/arm32v7/gazebo)](https://doi-janky.infosiftr.net/job/multiarch/job/arm32v7/job/gazebo/) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is a sad build history

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been tracked here #258 ,
perhaps we could poke it.

ruffsl added 4 commits August 9, 2019 10:38
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
@ruffsl ruffsl requested a review from mikaelarguedas August 9, 2019 17:55
Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants