Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of EOL Gazebo distros #118

Closed
mikaelarguedas opened this issue Jan 31, 2018 · 3 comments
Closed

Handling of EOL Gazebo distros #118

mikaelarguedas opened this issue Jan 31, 2018 · 3 comments

Comments

@mikaelarguedas
Copy link
Contributor

This is analog to #79 but for gazebo.

Several images in this repo are for EOL Gazebo distributions.
As it stands every time ubuntu releases a new image we rebuild all of the Gazebo images.

There are 2 approaches here:

  1. As long as a given ubuntu distribution is not EOL we should build up to date images for these platforms regardless of the state of the gazebo distribution (active / EOL)
  • pros: people get the latest security updates from ubuntu
  • cons:
    • we are shipping images in an untested state that doesnt reflect the state of the last supported configuration of that gazebo version
  • use resources to rebuild these (both our CI and the docker infrastructure)
  1. As soon as a Gazebo distribution is EOL, we stop building new images for it
    (pro / cons: opposite of option 1)

For ROS we decided to go for 1 as this matches the configuration when we stop building debian packages for a given distro. The same logic may or may not apply to gazebo.

/cc @ruffsl @j-rivero @nkoenig

@ruffsl
Copy link
Member

ruffsl commented Jan 31, 2018

I like 1, as from a user's perspective, I'd expect a package released into a distro would at least work up to the EOL for that same distro. However, perhaps such ideals are not always practical, given gazebo EOL is usually set months before Ubuntu's EOL for the targeted LTS.

@mikaelarguedas
Copy link
Contributor Author

However, perhaps such ideals are not always practical, given gazebo EOL is usually set months before Ubuntu's EOL for the targeted LTS.

Yeah as new versions of the package will not be released after it's EOL, I wouldn't expect anything to happen in case it breaks before the EOL of the platform, so I would be in favor of 2 (like for ROS).
That is actually what we will end up doing for Lunar: Lunar will EOL in may 2019 and we will stop building any ROS debs or docker images for it at that point, even though Ubuntu Xenial will not EOL before 2021.

@nkoenig @j-rivero Any comment on this ?

As Gazebo 4, 5 and 6 have been EOL for some time, I am considering doing like we do for ROS and stop building new images for them (aka removing them from the dockerlibrary as well as from CI of this repo).

@mikaelarguedas
Copy link
Contributor Author

Thanks everyone for the feedback (here and offline).
I believed we reached consensus and implemented the option "Stop building images for EOL versions of our projects (ROS and Gazebo) regardless of the EOL status of the base images" so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants