Add context and lock functionality to client interface #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aleksmaus @RebeccaMahany I know you've both poked around here. How's this approach feel? |
This was referenced May 27, 2023
There was a problem hiding this comment.
very cool way to use channels!
RebeccaMahany
approved these changes
May 30, 2023
aleksmaus
reviewed
Jun 1, 2023
|
Update: Fixed. Calling Unlock when unlocked, now panics. As it does with mutex. |
Co-authored-by: James Pickett <James-Pickett@users.noreply.github.com>
directionless
force-pushed
the
seph/context
branch
from
b6f784a
to
07fa160
Compare
RebeccaMahany
approved these changes
Jun 1, 2023
zwass
reviewed
Jun 6, 2023
Co-authored-by: Zach Wasserman <zach@fleetdm.com>
|
@zwass nudge nudge? |
|
@zwass @lucasmrod I'd love a thumb from y'all. Mostly because I don't want to inadvertently break what you're doing. I think there's enough support for this, so I'm going to end up merging it. But I do want to give y'all time to object / approve / etc |
|
Hearing no objections and tentative approval, I'm going to merge this. |
|
Yes that makes sense. I don't think this will cause any issues for us. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #98, the osquery thrift socket is can only handle a single caller.
In #99, I tried adding a mutex. But, with a mutex, it didn't feel like there was a good timeout behavior. Looking round, I considered a
rate.Limiter, but I find those very hard to understand. And eventually I found this suggestion for using single sized channels as a form of mutex.This should allow for exclusive locking, timeouts, and ctx cancelation.
I have also stopped exporting the raw osquery thrift client. Using it would bypass these locks, and feels like an antipattern. However, it does make this a breaking change.
I also bumped the go version because CI was complaining
Fixes: #98
Closes: #99