Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review design of IBC rewards distribution #81

Open
ethanfrey opened this issue Jun 28, 2023 · 0 comments
Open

Review design of IBC rewards distribution #81

ethanfrey opened this issue Jun 28, 2023 · 0 comments
Milestone

Comments

@ethanfrey
Copy link
Collaborator

ethanfrey commented Jun 28, 2023

We currently use a ConsumerPacket::DistributeRewards packet to send the tokens from consumer to distribute to the stakers on the provider. We need to review the semantics of that.

First, we need to allow multiple such packets in parallel, as we will want to distribute to all validators at the epoch. We may make one batch packet eg DistributeRewards (see #77) to match the two API calls on converter, which will do all work in one packet.

However, we also need some logic for rollback / commit on error / success, which is missing. It is unclear what needs to be done in an error case. How do we account for those tokens?

@ethanfrey ethanfrey added this to the TODO V1 milestone Jun 28, 2023
@maurolacy maurolacy changed the title Review design of IBC reward distribution Review design of IBC rewards distribution Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant