Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Track rebase of our work onto cosmos-sdk v0.45.0 #59

Closed
wants to merge 32 commits into from
Closed

refactor: Track rebase of our work onto cosmos-sdk v0.45.0 #59

wants to merge 32 commits into from

Conversation

sunnya97
Copy link

@sunnya97 sunnya97 commented Jan 23, 2022 •
edited
Loading

Description

Tracking rebase process of cherry picking our commits on top of upstream/v0.45.0

Part of osmosis-labs/osmosis#770

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@sunnya97 @ValarDragon
Add minimum commission rate to x/staking (#3)
c3f499c 
* add minimum commission rate

* fixed DefaultMinCommissionRate comment

* Update x/staking/keeper/params.go

* Update x/staking/keeper/validator.go

* Update x/staking/keeper/validator_test.go

* Update x/staking/keeper/validator_test.go

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

* Update x/staking/keeper/validator_test.go

* fix lint

* make proto-all

* fix lint

* add powerreduction to params

* check protobuf breakage against osmo-v0.42.x instead of master

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@sunnya97 sunnya97 force-pushed the sunny/rebase-v0.45 branch 2 times, most recently from ac975b1 to 17be746 Compare January 23, 2022 09:18
@sunnya97
Copy link
Author

We probably want to cherry-pick cosmos#10990

Should we "re-rebase" onto 0.45.1 once its released, or just cherry-pick the commit?

@ValarDragon

@ValarDragon
Copy link
Member

just the commit imo. Theres several such open PRs in the SDK to 45, and I don't think we should wait on them.

ValarDragon and others added 10 commits January 23, 2022 20:48
@ValarDragon @sunnya97
Turn off gocritic, nolintlint, and staticcheck. this isn't worth the …
2228736 
…time rn
@antstalepresh @sunnya97
min commission rate check on create validator (#11)
07832f2 
add MustUpdateValidatorCommission
@ValarDragon @sunnya97
Gate the change to processing of CreateValidatorMsg based on block he…
724eaa2 
…ight
@mconcat @ValarDragon @sunnya97
Add inplace decimal operations (#10)
be91975 
* add mutable decimal methods

* fix root

* gofmt

* add Clone(), rm assignment quo

* add SetInt64

* fix SetInt64

* More mut speedups

Co-authored-by: ValarDragon <dojha12@gmail.com>
@ValarDragon @sunnya97
Improve events heap allocations (#27)
1123355 
* Significantly lower number of heap allocations that should be required by events

* Use EmitEvent instead of EmitEvents
@ValarDragon @sunnya97
Deduplicate bech32 encoding
595544d
@mattverse @sunnya97
Add SendManyCoins, SendCoinsFromModuleToManyAccount method to bank Mo…
d5195b4 
…dule (#33)

* Add SenManyCoins method

* Add method SendCoinsFromModuleToManyAccounts in Bank module

* Lint
@sunnya97
fix bank keeper test
c9f662d
@ValarDragon @sunnya97
A notable variety of CacheKVStore improvements (#34)
8573d75 
* Try to fix the mutex contention

* downstream copy my pr for logs in initgenesis

* CacheKVStore linear factor improvements

* Reset map size (extremely important for unfortunate access patterns)

* Comment out module.go test for init genesis, assume logger lines are safe
@sunnya97
debug pubkey-raw
52af977
ValarDragon and others added 17 commits January 23, 2022 20:50
@ValarDragon @sunnya97
Add logging to RunMigrations
26abd7f
@ValarDragon @sunnya97
Expose Bank.NewAppModuleBasic
8481632
@ValarDragon @sunnya97
Bank store migration fix for Osmosis
4cac942
@ValarDragon @sunnya97
Cleanup prints during upgrade
f421dcb
@ValarDragon @sunnya97
Restore my old cacheKV store fix that got reverted >:(
ba9855a
@mattverse @sunnya97
Change default gas to 35k (#47)
282e9bb
@antstalepresh @sunnya97
add hooks for superfluid (#51)
ef80491
@mattverse @ValarDragon @sunnya97
fix: Change default pruning options (#52)
b87def6 
* Change default pruning settings

* Change config messages

* Change keep-every to 100k

* Updates

Co-authored-by: ValarDragon <dojha12@gmail.com>
@mattverse @sunnya97
Add safety check: restriction fn in bank module for mint perms (#50)
b47e802
@ValarDragon @sunnya97
Stop bank migration panic in tests (#55)
9799033 
Fixes the non-race test issue
@mattverse @sunnya97
feat: add default mint restriction (#57)
9d5d0c6 
* Add default minting restriction fn

* Minor changes
@ValarDragon @sunnya97
Make rechecking a tx check the sequence number (#58)
ee16076
@antstalepresh @sunnya97
reset bankmsg validatebasic for ics20
66c9626 
fix test
@antstalepresh @sunnya97
update bank send cli command generator
c88c9c8
@mattverse @sunnya97
fix liveness tests
0dcf83b
@sunnya97
fix proto checking against
88ad16d
@channa-figure @sunnya97
Add iavl-cache-size config parsing to GetConfig
f432981
@sunnya97
Copy link
Author

sunnya97 commented Jan 24, 2022 •
edited
Loading

Squashed a bunch of commits that were part of the same feature/issue

@sunnya97
Copy link
Author

@ValarDragon I shouldn't worry about the test-race (02) test failing, right?

@sunnya97 sunnya97 marked this pull request as ready for review January 24, 2022 06:48
@sunnya97 sunnya97 mentioned this pull request Jan 24, 2022
Merged
4 tasks
@ValarDragon
Copy link
Member

yeah test-race failing is not an issue

@sunnya97
Copy link
Author

What should I rename this branch to?

@ethanfrey
Copy link

ethanfrey commented Jan 26, 2022 •
edited
Loading

Awesome to see this progress.
And osmosis-labs/osmosis#782

I'm ready to finalise osmosis-labs/osmosis#769 once these are both merged (we tagged wasmd 0.22 yesterday with cosmos-sdk 0.45 support)

@ValarDragon
Copy link
Member

Looks like 3575fe5 ( MustUpdateValidatorCommission ) was dropped?

@ValarDragon
Copy link
Member

Note to self: dad6e87 is not included, need to configure the IAVL cache size param / config default prior to next release.

@ValarDragon
Copy link
Member

ValarDragon commented Jan 27, 2022 •
edited
Loading

This LGTM! I think we just need to cherry-pick back in 3575fe5

EDIT: I'm wrong, its in there somewhere.

Making a new branch off of this called v0.45.0x-osmo-v7, and setting as default

Thanks for doing this!

@ValarDragon ValarDragon mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:CLI C:Rosetta C:Simulations C:x/auth C:x/authz C:x/bank C:x/distribution C:x/gov C:x/slashing C:x/staking T:Build T:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sunnya97 @ValarDragon @ethanfrey @antstalepresh @mconcat @mattverse @channa-figure