From 0f44dbf0f80394f43d47249a65bd3504db2fe170 Mon Sep 17 00:00:00 2001 From: Dev Ojha Date: Tue, 4 Jun 2024 09:42:06 -0500 Subject: [PATCH] Update docs and add changelog --- .../3182-remove-switch-broadcast-return-channel.md | 0 p2p/switch.go | 5 +---- 2 files changed, 1 insertion(+), 4 deletions(-) create mode 100644 .changelog/unreleased/improvements/3182-remove-switch-broadcast-return-channel.md diff --git a/.changelog/unreleased/improvements/3182-remove-switch-broadcast-return-channel.md b/.changelog/unreleased/improvements/3182-remove-switch-broadcast-return-channel.md new file mode 100644 index 0000000000..e69de29bb2 diff --git a/p2p/switch.go b/p2p/switch.go index f4147dfc1f..22c94404cc 100644 --- a/p2p/switch.go +++ b/p2p/switch.go @@ -262,10 +262,7 @@ func (sw *Switch) OnStop() { // Peers // BroadcastEnvelope runs a go routine for each attempted send, which will block trying -// to send for defaultSendTimeoutSeconds. Returns a channel which receives -// success values for each attempted send (false if times out). Channel will be -// closed once msg bytes are sent to all peers (or time out). -// BroadcastEnvelopes sends to the peers using the SendEnvelope method. +// to send for defaultSendTimeoutSeconds. // // NOTE: BroadcastEnvelope uses goroutines, so order of broadcast may not be preserved. func (sw *Switch) BroadcastEnvelope(e Envelope) {