Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyring for signing (Signer-account) #46

Closed
Tracked by #52
daniel-farina opened this issue Jun 23, 2022 · 4 comments · Fixed by #74
Closed
Tracked by #52

Use keyring for signing (Signer-account) #46

daniel-farina opened this issue Jun 23, 2022 · 4 comments · Fixed by #74
Assignees
Labels
enhancement New feature or request ⚙️ task A task belongs to an epic
Milestone

Comments

@daniel-farina
Copy link
Contributor

For the signer-account option I think having a few predefined ones works well for localosmosis but for testnet/mainnet it would be best to use:

  • use system keyring so that I can use my own keys
  • option to specify the keyring backend

https://docs.cosmos.network/master/run-node/keyring.html

I guess we could call them:
system-signer-account && beaker-signer-account?

This way we can allow people to request testnet tokens via the faucet for their own addresses, and eventually add an option to the faucet to approve contracts as well as we discussed yesterday.

@daniel-farina daniel-farina added question Further information is requested ⚙️ task A task belongs to an epic labels Jun 28, 2022
@daniel-farina
Copy link
Contributor Author

Also @iboss-ptk asked:
What is the process with Ledger?

@daniel-farina
Copy link
Contributor Author

Maybe we should try to do this manually first to understand the process.

@iboss-ptk iboss-ptk self-assigned this Jun 28, 2022
@ValarDragon
Copy link
Member

Is the goal to wrap the Osmosisd cli, or to directly access the keyrings themselves?

@iboss-ptk
Copy link
Collaborator

Should bet the latter, I think.

@iboss-ptk iboss-ptk added this to the 0.0.5 milestone Jul 11, 2022
@iboss-ptk iboss-ptk added enhancement New feature or request and removed question Further information is requested labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ⚙️ task A task belongs to an epic
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants