Inline error check

oschwald · oschwald · commit e92e74b0bbdb · 2019-08-23T08:55:32.000-07:00
Previously, we were benchmarking the assert.NoError call, which isn't
particularly cheap.
diff --git a/reader_test.go b/reader_test.go
@@ -645,7 +645,9 @@ func BenchmarkLookup(b *testing.B) {
 	for i := 0; i < b.N; i++ {
 		randomIPv4Address(r, ip)
 		err = db.Lookup(ip, &result)
-		assert.NoError(b, err)
+		if err != nil {
+			b.Error(err)
+		}
 	}
 	assert.NoError(b, db.Close(), "error on close")
 }
@@ -667,7 +669,9 @@ func BenchmarkCountryCode(b *testing.B) {
 	for i := 0; i < b.N; i++ {
 		randomIPv4Address(r, ip)
 		err = db.Lookup(ip, &result)
-		assert.NoError(b, err)
+		if err != nil {
+			b.Error(err)
+		}
 	}
 	assert.NoError(b, db.Close(), "error on close")
 }

Original file line number	Diff line number	Diff line change
`@@ -645,7 +645,9 @@ func BenchmarkLookup(b *testing.B) {`
`645`	`645`	`for i := 0; i < b.N; i++ {`
`646`	`646`	`randomIPv4Address(r, ip)`
`647`	`647`	`err = db.Lookup(ip, &result)`
`648`		`- assert.NoError(b, err)`
	`648`	`+ if err != nil {`
	`649`	`+ b.Error(err)`
	`650`	`+ }`
`649`	`651`	`}`
`650`	`652`	`assert.NoError(b, db.Close(), "error on close")`
`651`	`653`	`}`
`@@ -667,7 +669,9 @@ func BenchmarkCountryCode(b *testing.B) {`
`667`	`669`	`for i := 0; i < b.N; i++ {`
`668`	`670`	`randomIPv4Address(r, ip)`
`669`	`671`	`err = db.Lookup(ip, &result)`
`670`		`- assert.NoError(b, err)`
	`672`	`+ if err != nil {`
	`673`	`+ b.Error(err)`
	`674`	`+ }`
`671`	`675`	`}`
`672`	`676`	`assert.NoError(b, db.Close(), "error on close")`
`673`	`677`	`}`