Skip to content

Commit dee4c2c

Browse files
committed
Fix lint config and pointer switch
Exclude our public API and external tests from revive's package-directory rule. Collapse the pointer offset switch to avoid identical branch warnings. Remove duplicate package comments to satisfy godoclint.
1 parent af17178 commit dee4c2c

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

.golangci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,11 @@ linters:
128128
disabled: true
129129
- name: nested-structs
130130
disabled: true
131+
- name: package-directory-mismatch
132+
severity: warning
133+
arguments:
134+
- ignore-directories:
135+
- maxminddb-golang
131136
- name: unchecked-type-assertion
132137
disabled: true
133138
- name: unhandled-error

internal/decoder/data_decoder.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Package decoder decodes values in the data section.
21
package decoder
32

43
import (
@@ -238,14 +237,12 @@ func (d *DataDecoder) decodePointer(
238237

239238
var pointerValueOffset uint
240239
switch pointerSize {
241-
case 1:
240+
case 1, 4:
242241
pointerValueOffset = 0
243242
case 2:
244243
pointerValueOffset = 2048
245244
case 3:
246245
pointerValueOffset = 526336
247-
case 4:
248-
pointerValueOffset = 0
249246
default:
250247
return 0, 0, mmdberrors.NewInvalidDatabaseError("invalid pointer size: %d", pointerSize)
251248
}

internal/decoder/decoder.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Package decoder provides low-level decoding utilities for MaxMind DB data.
12
package decoder
23

34
import (

internal/decoder/reflection.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Package decoder decodes values in the data section.
21
package decoder
32

43
import (

internal/decoder/string_cache.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Package decoder decodes values in the data section.
21
package decoder
32

43
import (

mmdbdata/type.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Package mmdbdata provides types and interfaces for working with MaxMind DB data.
21
package mmdbdata
32

43
import "github.com/oschwald/maxminddb-golang/v2/internal/decoder"

0 commit comments

Comments
 (0)