From 06dc01e7f4fd346197bdf19130f0f0d9e810cc94 Mon Sep 17 00:00:00 2001 From: Otto van der Schaaf Date: Tue, 4 Aug 2020 19:03:23 +0200 Subject: [PATCH] Review feedback Signed-off-by: Otto van der Schaaf --- extensions_build_config.bzl | 2 +- source/server/README.md | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/extensions_build_config.bzl b/extensions_build_config.bzl index bdfe8bd0b..a777b7fa4 100644 --- a/extensions_build_config.bzl +++ b/extensions_build_config.bzl @@ -1,4 +1,4 @@ -# See https://github.com/envoyproxy/envoy/blob/master/bazel/README.md for details on how this system works. +# See https://github.com/envoyproxy/envoy/blob/master/bazel/README.md#disabling-extensions for details on how this system works. EXTENSIONS = { "envoy.filters.http.router": "//source/extensions/filters/http/router:config", "envoy.filters.http.fault": "//source/extensions/filters/http/fault:config", diff --git a/source/server/README.md b/source/server/README.md index 7c39638bf..91a4d5c1b 100644 --- a/source/server/README.md +++ b/source/server/README.md @@ -8,17 +8,18 @@ A test-server filter which is capable of generating test responses. bazel test -c dbg //test/server:http_test_server_filter_integration_test ``` -It is possible to enable -[envoy extensions](https://github.com/envoyproxy/envoy/blob/master/source/extensions/extensions_build_config.bzl) by adding them [here](../../extensions_build_config.bzl) before the build. -By default, Nighthawk's test server is set up with the minimum extension set needed -for it to operate as documented. - ## Building ```bash bazel build -c opt :nighthawk_test_server ``` +It is possible to +[enable additional envoy extension](https://github.com/envoyproxy/envoy/blob/master/source/extensions/extensions_build_config.bzl) by adding them [here](../../extensions_build_config.bzl) before the build. +By default, Nighthawk's test server is set up with the minimum extension set needed +for it to operate as documented. + + ## Configuring the test server `test-server.yaml` sample content