Try enabling some tests again #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures, see oscar-system#3947 (oscar-system#3960)" This reverts commit a096328.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4113 +/- ##
==========================================
+ Coverage 84.66% 84.68% +0.01%
==========================================
Files 626 626
Lines 84210 84210
==========================================
+ Hits 71300 71316 +16
+ Misses 12910 12894 -16 |
|
CI is all green. I restart now to verify that we just not had a lot of luck with randomness. |
benlorenz
approved these changes
Sep 19, 2024
|
There was an (supposedly unrelated) segmentation fault in the Lie algebra tests, which I now restarted. Otherwise it looks good. |
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 30, 2024
…ilures, see oscar-system#3947 (oscar-system#3960)" (oscar-system#4113) This reverts commit a096328.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that some of caching in the algebraic geometry code is disabled, maybe these tests work again, see #3947 and #3960.