Prepare for name printing changes in AA #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Feb 6, 2024
joschmitt
reviewed
Feb 6, 2024
| @@ -1162,7 +1162,7 @@ base_ring(f::MPolyDecRingElem) = base_ring(forget_decoration(f)) | |||
|
|
|||
| function show_homo_comp(io::IO, M) | |||
| (W, d) = get_attribute(M, :data) | |||
| n = get_attribute(W, :name) | |||
| n = AbstractAlgebra.find_name(W) | |||
| io = pretty(io) | |||
| if n !== nothing | |||
| print(io, LowercaseOff(), "$(n)_$(d.coeff) of dim $(dim(M))") | |||
There was a problem hiding this comment.
Suggested change
| print(io, LowercaseOff(), "$(n)_$(d.coeff) of dim $(dim(M))") | |
| print(io, LowercaseOff(), "$(n)_") | |
| print(IOContext(io, :supercompact => true), d) | |
| print(io, " of dim $(dim(M))") |
Should work too and would be more consistent regarding commas in the degree.
There was a problem hiding this comment.
I would like this PR to get going fast. There will be a follow up once Nemocas/AbstractAlgebra.jl#1594 is released anyway, where I will incorporate this change
|
@fingolfin can you merge this so I can get going with Nemocas/AbstractAlgebra.jl#1594? |
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
* Prepare for name printing changes in AA * Adjust doctests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Nemocas/AbstractAlgebra.jl#1594 non-breaking by using the interface instead of internals (see Nemocas/AbstractAlgebra.jl#1594 (comment))