-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for name printing changes in AA #3318
Conversation
@@ -1162,7 +1162,7 @@ base_ring(f::MPolyDecRingElem) = base_ring(forget_decoration(f)) | |||
|
|||
function show_homo_comp(io::IO, M) | |||
(W, d) = get_attribute(M, :data) | |||
n = get_attribute(W, :name) | |||
n = AbstractAlgebra.find_name(W) | |||
io = pretty(io) | |||
if n !== nothing | |||
print(io, LowercaseOff(), "$(n)_$(d.coeff) of dim $(dim(M))") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print(io, LowercaseOff(), "$(n)_$(d.coeff) of dim $(dim(M))") | |
print(io, LowercaseOff(), "$(n)_") | |
print(IOContext(io, :supercompact => true), d) | |
print(io, " of dim $(dim(M))") |
Should work too and would be more consistent regarding commas in the degree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like this PR to get going fast. There will be a follow up once Nemocas/AbstractAlgebra.jl#1594 is released anyway, where I will incorporate this change
@fingolfin can you merge this so I can get going with Nemocas/AbstractAlgebra.jl#1594? |
* Prepare for name printing changes in AA * Adjust doctests
Makes Nemocas/AbstractAlgebra.jl#1594 non-breaking by using the interface instead of internals (see Nemocas/AbstractAlgebra.jl#1594 (comment))