From f71b1e4e14976f0bd13b98aa272e098a2ad6eef1 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 7 Feb 2024 13:39:36 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Lars Göttgens --- experimental/GModule/Cohomology.jl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/experimental/GModule/Cohomology.jl b/experimental/GModule/Cohomology.jl index 8e4086fa328c..f4d8fe6cf8f3 100644 --- a/experimental/GModule/Cohomology.jl +++ b/experimental/GModule/Cohomology.jl @@ -1719,7 +1719,10 @@ function ==(a::Union{Generic.ModuleHomomorphism, Generic.ModuleIsomorphism}, b:: end function Base.hash(a::Union{Generic.ModuleHomomorphism, Generic.ModuleIsomorphism}, h::UInt) - return hash(matrix(a), h) + h = hash(domain(a), h) + h = hash(codomain(a), h) + h = hash(matrix(a), h) + return h end function Oscar.id_hom(A::AbstractAlgebra.FPModule)