Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Thanks Lars and Max :)

Co-authored-by: Max Horn <max@quendi.de>
  • Loading branch information
Sequenzer and fingolfin authored Jul 19, 2024
1 parent 11eec61 commit 588f546
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
12 changes: 2 additions & 10 deletions src/Combinatorics/Matroids/quantum_automorphism_groups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,8 @@ function _quantum_automorphism_group_indices(M::Matroid, structure::Symbol=:base
end
for set in b[size]
for nonset in nb[size]
rel = []
for i in 1:size
push!(rel,(set[i],nonset[i]))
end
push!(rels[size],rel)
rel = []
for i in 1:size
push!(rel,(nonset[i],set[i]))
end
push!(rels[size],rel)
push!(rels[size], [(set[i],nonset[i]) for i in 1:size])
push!(rels[size], [(nonset[i],set[i]) for i in 1:size])
end
end
end
Expand Down
6 changes: 5 additions & 1 deletion src/Rings/FreeAssAlgIdeal.jl
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ _to_lpring(a::FreeAssAlgebra, deg_bound::Int) = Singular.FreeAlgebra(base_ring(a
@doc raw"""
groebner_basis(I::FreeAssAlgIdeal, deg_bound::Int=-1; protocol::Bool=false)
Return the Groebner basis of `I` with respect to the degree bound `deg_bound`. If `protocol` is `true`, the protocol of the computation is also returned. The default value of `deg_bound` is `-1`, which means that no degree bound is imposed, resulting in a computation that is usually slower, but will return a full Groebner basis if there exists a finite one.
Return the Groebner basis of `I` with respect to the degree bound `deg_bound`.
If `protocol` is `true`, the protocol of the computation is also returned.
The default value of `deg_bound` is `-1`, which means that no degree bound is
imposed, resulting in a computation that is usually slower, but will return a
full Groebner basis if there exists a finite one.
```jldoctest
julia> free, (x,y,z) = free_associative_algebra(QQ, ["x", "y", "z"]);
Expand Down

0 comments on commit 588f546

Please sign in to comment.