-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GAP 4.12.1 #835
Merged
Merged
Update to GAP 4.12.1 #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a4c0fe
to
68a9ec4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 81.50% 81.57% +0.06%
==========================================
Files 48 48
Lines 3688 3653 -35
==========================================
- Hits 3006 2980 -26
+ Misses 682 673 -9
|
3b08d2a
to
e5a3ab3
Compare
e5a3ab3
to
304078d
Compare
The Oscar tests fails because GAP changed (fixed) its definition for "transitivity degree" when given a domain which is not closed under the action of the given group. |
fc5ceef
to
6d2ffba
Compare
Unfortunately the Oscar test suite segfaults with this GAP.jl update plus oscar-system/Oscar.jl#1671, at least on my M1 MacBook
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #836
Resolves #821
Resolves #812
Resolves #786