Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GAP 4.12.1 #835

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 27, 2022

Resolves #836
Resolves #821
Resolves #812
Resolves #786

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #835 (6d2ffba) into master (dd21ba1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   81.50%   81.57%   +0.06%     
==========================================
  Files          48       48              
  Lines        3688     3653      -35     
==========================================
- Hits         3006     2980      -26     
+ Misses        682      673       -9     
Impacted Files Coverage Δ
gap/systemfile.g 100.00% <100.00%> (ø)
pkg/JuliaExperimental/PackageInfo.g 100.00% <100.00%> (ø)
pkg/JuliaInterface/PackageInfo.g 90.09% <100.00%> (ø)
src/setup.jl 79.31% <100.00%> (-2.15%) ⬇️
src/julia_to_gap.jl 91.75% <0.00%> (+2.06%) ⬆️
src/packages.jl 67.79% <0.00%> (+5.08%) ⬆️

@fingolfin fingolfin changed the title Update to GAP 4.12.1 (WIP) Update to GAP 4.12.1 Oct 31, 2022
@fingolfin fingolfin marked this pull request as ready for review November 1, 2022 21:26
@fingolfin
Copy link
Member Author

The Oscar tests fails because GAP changed (fixed) its definition for "transitivity degree" when given a domain which is not closed under the action of the given group.

@fingolfin
Copy link
Member Author

fingolfin commented Nov 1, 2022

Unfortunately the Oscar test suite segfaults with this GAP.jl update plus oscar-system/Oscar.jl#1671, at least on my M1 MacBook

Test Summary:                            | Pass  Total  Time
describe() for finitely presented groups |    6      6  0.1s

signal (11): Segmentation fault: 11
in expression starting at /Users/mhorn/Projekte/OSCAR/Oscar.jl/test/Groups/describe.jl:79
DoExecFunc1args at /Users/mhorn/.julia/artifacts/fb4093a2787ae817d48f3ac7c1e1b99712456dbf/lib/libgap.8.dylib (unknown line)
Allocations: 304036272 (Pool: 303878774; Big: 157498); GC: 67

signal (11): Segmentation fault: 11
in expression starting at /Users/mhorn/Projekte/OSCAR/Oscar.jl/test/Groups/describe.jl:79
DoExecFunc0args at /Users/mhorn/.julia/artifacts/fb4093a2787ae817d48f3ac7c1e1b99712456dbf/lib/libgap.8.dylib (unknown line)
_call_gap_func at /Users/mhorn/Projekte/OSCAR/GAP.jl/src/ccalls.jl:251
call_gap_func_nokw at /Users/mhorn/Projekte/OSCAR/GAP.jl/src/ccalls.jl:224 [inlined]
GapObj at /Users/mhorn/Projekte/OSCAR/GAP.jl/src/ccalls.jl:234
unknown function (ip: 0x313f800db)
ijl_apply_generic at /Users/mhorn/Applications/Julia-1.8.2.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
#1 at /Users/mhorn/Projekte/OSCAR/GAP.jl/src/GAP.jl:234
unknown function (ip: 0x313f6814f)
ijl_apply_generic at /Users/mhorn/Applications/Julia-1.8.2.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
_atexit at ./initdefs.jl:372
unknown function (ip: 0x313f501df)
ijl_apply_generic at /Users/mhorn/Applications/Julia-1.8.2.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
ijl_atexit_hook at /Users/mhorn/Applications/Julia-1.8.2.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
ijl_exit at /Users/mhorn/Applications/Julia-1.8.2.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
jl_exit_thread0_cb at /Users/mhorn/Applications/Julia-1.8.2.app/Contents/Resources/julia/lib/julia/libjulia-internal.1.8.dylib (unknown line)
Allocations: 304036272 (Pool: 303878774; Big: 157498); GC: 67
ERROR: Package Oscar errored during testing (exit code: 139)

@fingolfin fingolfin merged commit d47ef18 into oscar-system:master Nov 1, 2022
@fingolfin fingolfin deleted the mh/gap-4.12 branch November 1, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant